From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Joe Perches <joe@perches.com>
Cc: <ath6kl-devel@qualcomm.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 03/12] ath6kl: alignment should match open parenthesis
Date: Wed, 7 Mar 2012 22:18:36 +0200 [thread overview]
Message-ID: <4F57C29C.1050900@qca.qualcomm.com> (raw)
In-Reply-To: <1331148403.2140.67.camel@joe2Laptop>
On 03/07/2012 09:26 PM, Joe Perches wrote:
> On Wed, 2012-02-29 at 19:18 +0200, Kalle Valo wrote:
>> Fix the issues which checkpatch found and were easy to fix. Especially
>> callers of ath6kl_bmi_write() are tricky and that needs to be fixed
>> separately.
>
> Just a trivial note.
>
>> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> []
>> @@ -390,7 +390,7 @@ static bool ath6kl_is_valid_iftype(struct ath6kl *ar, enum nl80211_iftype type,
>> return false;
>>
>> if (ar->ibss_if_active || ((type == NL80211_IFTYPE_ADHOC) &&
>> - ar->num_vif))
>> + ar->num_vif))
>
> I think this would be better as:
>
> if (ar->ibss_if_active ||
> (type == NL80211_IFTYPE_ADHOC && ar->num_vif))
>
> Bundling dependent tests on a single line is sensible.
I agree, but I just pushed this patch and I can't change it anymore. I
try to remember this in the future.
Kalle
next prev parent reply other threads:[~2012-03-07 20:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 17:18 [PATCH 00/12] ath6kl: checkpatch fixes Kalle Valo
2012-02-29 17:18 ` [PATCH 01/12] ath6kl: fix pointer style Kalle Valo
2012-02-29 17:18 ` [PATCH 02/12] ath6kl: fix checkpatch error with EPSTAT() macro Kalle Valo
2012-02-29 17:18 ` [PATCH 03/12] ath6kl: alignment should match open parenthesis Kalle Valo
2012-03-07 19:26 ` Joe Perches
2012-03-07 20:18 ` Kalle Valo [this message]
2012-02-29 17:19 ` [PATCH 04/12] ath6kl: logical continuations should be on the previous line Kalle Valo
2012-02-29 17:19 ` [PATCH 05/12] ath6kl: remove multiple assignments Kalle Valo
2012-02-29 17:19 ` [PATCH 06/12] ath6kl: add ath6kl_bmi_write_hi32() Kalle Valo
2012-02-29 17:19 ` [PATCH 07/12] ath6kl: add ath6kl_bmi_read_hi32() Kalle Valo
2012-02-29 17:19 ` [PATCH 08/12] ath6kl: fix error handling ath6kl_target_config_wlan_params() Kalle Valo
2012-02-29 17:19 ` [PATCH 09/12] ath6kl: fix open paranthesis alignment in ath6kl_cfg80211_connect() Kalle Valo
2012-02-29 17:19 ` [PATCH 10/12] ath6kl: document all spinlocks Kalle Valo
2012-02-29 17:20 ` [PATCH 11/12] ath6kl: fix too long lines Kalle Valo
2012-02-29 17:20 ` [PATCH 12/12] ath6kl: make ath6kl_bmi_[read|write]_hi32() endian safe Kalle Valo
2012-02-29 17:37 ` [PATCH 00/12] ath6kl: checkpatch fixes Joe Perches
2012-02-29 17:41 ` Kalle Valo
2012-02-29 18:21 ` Joe Perches
2012-03-05 16:33 ` Kalle Valo
2012-03-07 17:57 ` Kalle Valo
2012-03-07 18:37 ` Joe Perches
2012-03-07 19:01 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F57C29C.1050900@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).