* [PATCH] mac80211: Don't sample max throughput rate in minstrel_ht
@ 2012-03-14 12:31 Helmut Schaa
2012-03-14 12:46 ` Felix Fietkau
0 siblings, 1 reply; 2+ messages in thread
From: Helmut Schaa @ 2012-03-14 12:31 UTC (permalink / raw)
To: linux-wireless; +Cc: linville, johannes, nbd, Helmut Schaa
The current max throughput rate is known to be good as otherwise it
wouldn't be the max throughput rate. Since rate sampling can introduce
some overhead (by adding RTS for example or due to not aggregating the
frame) don't sample the max throughput rate.
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
---
net/mac80211/rc80211_minstrel_ht.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c
index dbe3dd3..dc40b7b 100644
--- a/net/mac80211/rc80211_minstrel_ht.c
+++ b/net/mac80211/rc80211_minstrel_ht.c
@@ -591,6 +591,13 @@ minstrel_get_sample_rate(struct minstrel_priv *mp, struct minstrel_ht_sta *mi)
minstrel_next_sample_idx(mi);
/*
+ * Sampling might add some overhead (RTS, no aggregation)
+ * to the frame. Hence, don't use sampling for the currently
+ * used max TP rate.
+ */
+ if (sample_idx == mi->max_tp_rate)
+ return -1;
+ /*
* When not using MRR, do not sample if the probability is already
* higher than 95% to avoid wasting airtime
*/
--
1.7.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mac80211: Don't sample max throughput rate in minstrel_ht
2012-03-14 12:31 [PATCH] mac80211: Don't sample max throughput rate in minstrel_ht Helmut Schaa
@ 2012-03-14 12:46 ` Felix Fietkau
0 siblings, 0 replies; 2+ messages in thread
From: Felix Fietkau @ 2012-03-14 12:46 UTC (permalink / raw)
To: Helmut Schaa; +Cc: linux-wireless, linville, johannes
On 2012-03-14 1:31 PM, Helmut Schaa wrote:
> The current max throughput rate is known to be good as otherwise it
> wouldn't be the max throughput rate. Since rate sampling can introduce
> some overhead (by adding RTS for example or due to not aggregating the
> frame) don't sample the max throughput rate.
>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
Acked-by: Felix Fietkau <nbd@openwrt.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-14 12:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-14 12:31 [PATCH] mac80211: Don't sample max throughput rate in minstrel_ht Helmut Schaa
2012-03-14 12:46 ` Felix Fietkau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).