From: Felix Fietkau <nbd@openwrt.org>
To: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
rodrigue@qca.qualcomm.com
Subject: Re: [PATCH 03/14] ath9k_hw: remove ath9k_hw_htc_resetinit
Date: Thu, 15 Mar 2012 09:15:02 +0100 [thread overview]
Message-ID: <4F61A506.9010309@openwrt.org> (raw)
In-Reply-To: <20321.33695.439509.73251@gargle.gargle.HOWL>
On 2012-03-15 6:52 AM, Sujith Manoharan wrote:
> Felix Fietkau wrote:
>> Automatically set the ah->htc_reset_init on init and after PHY disable.
>>
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>> ---
>> drivers/net/wireless/ath/ath9k/htc_drv_main.c | 1 -
>> drivers/net/wireless/ath/ath9k/hw.c | 8 ++------
>> drivers/net/wireless/ath/ath9k/hw.h | 3 ---
>> 3 files changed, 2 insertions(+), 10 deletions(-)
>
> ath9k_htc still has remnants of the old radio enable/disable code when
> drivers were handling RFKILL events. And until that area is cleaned up,
> this should probably be kept - since PHY disable is done there too, and
> we are fiddling with RST/RF registers.
I did see the old radio enabled/disable code and my patch preserves the
existing behavior. ath9k_hw_phy_disable sets ah->htc_reset_init = true,
so the first reset called by ath9k_htc_start() will trigger the extra
reset just like before.
- Felix
prev parent reply other threads:[~2012-03-15 8:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 15:40 [PATCH 01/14] ath9k_hw: simplify tx queue interrupt mask handling Felix Fietkau
2012-03-14 15:40 ` [PATCH 02/14] ath9k_hw: clean up tx completion interrupt handling Felix Fietkau
2012-03-14 15:40 ` [PATCH 03/14] ath9k_hw: remove ath9k_hw_htc_resetinit Felix Fietkau
2012-03-14 15:40 ` [PATCH 04/14] ath9k_hw: remove ath9k_hw_getdefantenna Felix Fietkau
2012-03-14 15:40 ` [PATCH 05/14] ath9k: optimize register access functions Felix Fietkau
2012-03-14 15:40 ` [PATCH 06/14] ath9k_hw: remove ath9k_hw_gettxintrtxqs Felix Fietkau
2012-03-14 15:40 ` [PATCH 07/14] ath9k_hw: clean up ath9k_hw_setuprxdesc Felix Fietkau
2012-03-14 15:40 ` [PATCH 08/14] ath9k_hw: remove iniCommon_*_cck_fir_coeff_9271 Felix Fietkau
2012-03-14 15:40 ` [PATCH 09/14] ath9k_hw: fold ar9002_hw_cck_chan14_spread into mode regs initialization Felix Fietkau
2012-03-14 15:40 ` [PATCH 10/14] ath9k_hw: fix AR9380 register settings for channel 14 Felix Fietkau
2012-03-14 15:40 ` [PATCH 11/14] ath9k_hw: clean up iniModesAdditional Felix Fietkau
2012-03-14 15:40 ` [PATCH 12/14] ath9k_hw: remove iniModes_*_tx_gain_9271 Felix Fietkau
2012-03-14 15:40 ` [PATCH 13/14] ath9k: inline AR9271 1.0 INI overrides Felix Fietkau
2012-03-14 15:40 ` [PATCH 14/14] ath9k_hw: remove unused initvals Felix Fietkau
2012-03-15 5:52 ` [PATCH 03/14] ath9k_hw: remove ath9k_hw_htc_resetinit Sujith Manoharan
2012-03-15 8:15 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F61A506.9010309@openwrt.org \
--to=nbd@openwrt.org \
--cc=c_manoha@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).