linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/2] mac80211:  Support getting sta_info stats via ethtool.
Date: Thu, 15 Mar 2012 11:56:24 -0700	[thread overview]
Message-ID: <4F623B58.1070106@candelatech.com> (raw)
In-Reply-To: <1331837531.3432.36.camel@jlt3.sipsolutions.net>

On 03/15/2012 11:52 AM, Johannes Berg wrote:
> On Thu, 2012-03-15 at 10:39 -0700, greearb@candelatech.com wrote:
>> From: Ben Greear<greearb@candelatech.com>
>>
>> This lets ethtool print out stats related to station
>> interfaces.  Does not yet get stats from the underlying
>> driver.
>
> Hmm. What's the advantage of using ethtool over iw, which already has a
> bunch of these numbers?

Well, ethtool api might be easier for some apps to use,
and perhaps easier for users to read if all they want
are stats.

But, I also plan to add stats from the underlying
driver with and additional (optional) call down
to the driver, and I think we would not ever want to
add that to netlink API.

That way, we can add internal ath9k counters and
such instead of having to use debugfs.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  reply	other threads:[~2012-03-15 18:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15 17:39 [RFC 1/2] cfg80211: Add framework to support ethtool stats greearb
2012-03-15 17:39 ` [RFC 2/2] mac80211: Support getting sta_info stats via ethtool greearb
2012-03-15 18:52   ` Johannes Berg
2012-03-15 18:56     ` Ben Greear [this message]
2012-03-16 13:49       ` John W. Linville
2012-03-16 14:18         ` Florian Fainelli
2012-03-16 14:54           ` Ben Greear
2012-03-16 14:59             ` Florian Fainelli
2012-03-16 16:39               ` Ben Greear
2012-03-16 17:14               ` Rick Jones
2012-03-15 18:55   ` Johannes Berg
2012-03-15 19:03     ` Ben Greear
2012-03-15 19:05       ` Johannes Berg
2012-03-15 18:50 ` [RFC 1/2] cfg80211: Add framework to support ethtool stats Johannes Berg
2012-03-15 18:52   ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F623B58.1070106@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).