From: "Arend van Spriel" <arend@broadcom.com>
To: "Hauke Mehrtens" <hauke@hauke-m.de>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
"ralf@linux-mips.org" <ralf@linux-mips.org>,
"m@bues.ch" <m@bues.ch>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"zajec5@gmail.com" <zajec5@gmail.com>
Subject: Re: [PATCH v5 4/4] USB: OHCI: remove old SSB OHCI driver
Date: Fri, 16 Mar 2012 10:05:43 +0100 [thread overview]
Message-ID: <4F630267.5050909@broadcom.com> (raw)
In-Reply-To: <1331851799-5968-5-git-send-email-hauke@hauke-m.de>
On 03/15/2012 11:49 PM, Hauke Mehrtens wrote:
> This is now replaced by the new ssb USB driver, which also supports
> devices with an EHCI controller.
>
> Signed-off-by: Hauke Mehrtens<hauke@hauke-m.de>
> ---
> drivers/usb/host/Kconfig | 7 +-
> drivers/usb/host/ohci-hcd.c | 21 +----
> drivers/usb/host/ohci-ssb.c | 260 -------------------------------------------
> 3 files changed, 7 insertions(+), 281 deletions(-)
> delete mode 100644 drivers/usb/host/ohci-ssb.c
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 2fc5637..00b6fc8 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -373,10 +373,15 @@ config USB_OHCI_HCD_PCI
> If unsure, say Y.
>
> config USB_OHCI_HCD_SSB
> - bool "OHCI support for Broadcom SSB OHCI core"
> + bool "OHCI support for Broadcom SSB OHCI core (DEPRECATED)"
> depends on USB_OHCI_HCD&& (SSB = y || SSB = USB_OHCI_HCD)&& EXPERIMENTAL
> + select USB_HCD_SSB
> + select USB_OHCI_HCD_PLATFORM
> default n
> ---help---
> + This option is deprecated now and the driver was removed, use
> + USB_HCD_SSB and USB_OHCI_HCD_PLATFORM instead.
> +
> Support for the Sonics Silicon Backplane (SSB) attached
> Broadcom USB OHCI core.
Looks fine as it helps transitioning old .config files. Should the
select statements be mentioned in the help section, ie. 'using' iso 'use'.
Gr. AvS
next prev parent reply other threads:[~2012-03-16 9:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 22:49 [PATCH v5 0/4] USB: OHCI/EHCI: generic platform driver Hauke Mehrtens
2012-03-15 22:49 ` [PATCH v5 1/4] bcma: scan for extra address space Hauke Mehrtens
2012-04-13 11:58 ` Hauke Mehrtens
2012-03-15 22:49 ` [PATCH v5 2/4] USB: Add driver for the bcma bus Hauke Mehrtens
2012-03-15 22:49 ` [PATCH v5 3/4] USB: Add driver for the ssb bus Hauke Mehrtens
2012-03-15 22:49 ` [PATCH v5 4/4] USB: OHCI: remove old SSB OHCI driver Hauke Mehrtens
2012-03-16 9:05 ` Arend van Spriel [this message]
2012-03-16 15:35 ` Hauke Mehrtens
2012-04-18 20:44 ` [PATCH v5 0/4] USB: OHCI/EHCI: generic platform driver Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F630267.5050909@broadcom.com \
--to=arend@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=hauke@hauke-m.de \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
--cc=ralf@linux-mips.org \
--cc=stern@rowland.harvard.edu \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).