From: Felix Fietkau <nbd@openwrt.org>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/4] ath9k: Support ethtool getstats api.
Date: Fri, 16 Mar 2012 16:06:16 +0100 [thread overview]
Message-ID: <4F6356E8.3050906@openwrt.org> (raw)
In-Reply-To: <1331853606-28434-4-git-send-email-greearb@candelatech.com>
On 2012-03-16 12:20 AM, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> This returns many of the values that formerly could
> only be obtained from debugfs. This should be an
> improvement when trying to access these counters
> programatically. Currently this support is only
> enabled when DEBUGFS is enabled because otherwise
> these stats are not accumulated.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
I don't really like the idea just throwing every random counter into
ethtool. Many of these counters are actually quite misleading, not
properly tracked, or not even updated properly, and thus do not deserve
to be made visible through ethtool.
I think before something gets exported that way, it should be made clear
what it's for and what the limitations are.
- Felix
next prev parent reply other threads:[~2012-03-16 15:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 23:20 [PATCH 1/4] cfg80211: Add framework to support ethtool stats greearb
2012-03-15 23:20 ` [PATCH 2/4] mac80211: Support getting sta_info stats via ethtool greearb
2012-03-15 23:20 ` [PATCH 3/4] mac80211: Framework to get wifi-driver " greearb
2012-03-16 8:54 ` Johannes Berg
2012-03-15 23:20 ` [PATCH 4/4] ath9k: Support ethtool getstats api greearb
2012-03-16 15:06 ` Felix Fietkau [this message]
2012-03-16 16:23 ` Ben Greear
2012-03-16 16:36 ` Felix Fietkau
2012-03-16 16:51 ` Ben Greear
2012-03-16 17:06 ` Felix Fietkau
2012-03-16 18:37 ` Ben Greear
2012-03-16 8:50 ` [PATCH 1/4] cfg80211: Add framework to support ethtool stats Johannes Berg
2012-03-16 10:05 ` Florian Fainelli
2012-03-16 15:06 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6356E8.3050906@openwrt.org \
--to=nbd@openwrt.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).