From: Ben Greear <greearb@candelatech.com>
To: Florian Fainelli <florian@openwrt.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/4] cfg80211: Add framework to support ethtool stats.
Date: Fri, 16 Mar 2012 08:06:24 -0700 [thread overview]
Message-ID: <4F6356F0.5060307@candelatech.com> (raw)
In-Reply-To: <4F631087.4040509@openwrt.org>
On 03/16/2012 03:05 AM, Florian Fainelli wrote:
> Hi,
>
> I do not think this is particularly a good idea to make eththool report wireless interfaces statistics:
> - these are 802.11 interfaces and so they have specific statistics to report which are different from pure ethernet adapters
> - people will start adding more statistics to ethtool because this or that wifi-specific counter is not reported, it is abusing the tool imho.
The ethtool stats are designed to display custom driver stats in a somewhat standard manner. There is no
expectation as to what stats are or should be available..some new wired Intel drivers report great numbers of
stats, and some drivers report none.
But, assuming we do not change the stat names all the time (adding new ones or re-arranging order is fine),
a tool can be written to parse the stats on a per-driver basis without much difficulty.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2012-03-16 15:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 23:20 [PATCH 1/4] cfg80211: Add framework to support ethtool stats greearb
2012-03-15 23:20 ` [PATCH 2/4] mac80211: Support getting sta_info stats via ethtool greearb
2012-03-15 23:20 ` [PATCH 3/4] mac80211: Framework to get wifi-driver " greearb
2012-03-16 8:54 ` Johannes Berg
2012-03-15 23:20 ` [PATCH 4/4] ath9k: Support ethtool getstats api greearb
2012-03-16 15:06 ` Felix Fietkau
2012-03-16 16:23 ` Ben Greear
2012-03-16 16:36 ` Felix Fietkau
2012-03-16 16:51 ` Ben Greear
2012-03-16 17:06 ` Felix Fietkau
2012-03-16 18:37 ` Ben Greear
2012-03-16 8:50 ` [PATCH 1/4] cfg80211: Add framework to support ethtool stats Johannes Berg
2012-03-16 10:05 ` Florian Fainelli
2012-03-16 15:06 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6356F0.5060307@candelatech.com \
--to=greearb@candelatech.com \
--cc=florian@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).