* [PATCH 1/2] rtlwifi: Use is_zero_ether_addr, remove line continuation
@ 2012-03-17 19:13 Joe Perches
2012-03-17 21:14 ` Larry Finger
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2012-03-17 19:13 UTC (permalink / raw)
To: Larry Finger, Chaoming Li
Cc: John W. Linville, linux-wireless, netdev, linux-kernel
Use the normal kernel facilities and use %pM
to print the all zero mac address.
Remove unnecessary line continuation.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/wireless/rtlwifi/cam.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/cam.c b/drivers/net/wireless/rtlwifi/cam.c
index 5c7d579..3d8cc4a 100644
--- a/drivers/net/wireless/rtlwifi/cam.c
+++ b/drivers/net/wireless/rtlwifi/cam.c
@@ -328,10 +328,9 @@ void rtl_cam_del_entry(struct ieee80211_hw *hw, u8 *sta_addr)
RT_TRACE(rtlpriv, COMP_SEC, DBG_EMERG, "sta_addr is NULL\n");
}
- if ((sta_addr[0]|sta_addr[1]|sta_addr[2]|sta_addr[3]|\
- sta_addr[4]|sta_addr[5]) == 0) {
+ if (is_zero_ether_addr(sta_addr)) {
RT_TRACE(rtlpriv, COMP_SEC, DBG_EMERG,
- "sta_addr is 00:00:00:00:00:00\n");
+ "sta_addr is %pM\n", sta_addr);
return;
}
/* Does STA already exist? */
--
1.7.8.111.gad25c.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] rtlwifi: Use is_zero_ether_addr, remove line continuation
2012-03-17 19:13 [PATCH 1/2] rtlwifi: Use is_zero_ether_addr, remove line continuation Joe Perches
@ 2012-03-17 21:14 ` Larry Finger
2012-03-17 21:18 ` Joe Perches
2012-03-17 21:18 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Larry Finger @ 2012-03-17 21:14 UTC (permalink / raw)
To: Joe Perches
Cc: Chaoming Li, John W. Linville, linux-wireless, netdev,
linux-kernel
On 03/17/2012 02:13 PM, Joe Perches wrote:
> Use the normal kernel facilities and use %pM
> to print the all zero mac address.
>
> Remove unnecessary line continuation.
>
> Signed-off-by: Joe Perches<joe@perches.com>
> ---
> drivers/net/wireless/rtlwifi/cam.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
ACKed-by: Larry.Finger@lwfinger.net
Is there a PATCH 2/2? I did not receive it.
Larry
>
> diff --git a/drivers/net/wireless/rtlwifi/cam.c b/drivers/net/wireless/rtlwifi/cam.c
> index 5c7d579..3d8cc4a 100644
> --- a/drivers/net/wireless/rtlwifi/cam.c
> +++ b/drivers/net/wireless/rtlwifi/cam.c
> @@ -328,10 +328,9 @@ void rtl_cam_del_entry(struct ieee80211_hw *hw, u8 *sta_addr)
> RT_TRACE(rtlpriv, COMP_SEC, DBG_EMERG, "sta_addr is NULL\n");
> }
>
> - if ((sta_addr[0]|sta_addr[1]|sta_addr[2]|sta_addr[3]|\
> - sta_addr[4]|sta_addr[5]) == 0) {
> + if (is_zero_ether_addr(sta_addr)) {
> RT_TRACE(rtlpriv, COMP_SEC, DBG_EMERG,
> - "sta_addr is 00:00:00:00:00:00\n");
> + "sta_addr is %pM\n", sta_addr);
> return;
> }
> /* Does STA already exist? */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] rtlwifi: Use is_zero_ether_addr, remove line continuation
2012-03-17 21:14 ` Larry Finger
@ 2012-03-17 21:18 ` Joe Perches
2012-03-17 21:18 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Joe Perches @ 2012-03-17 21:18 UTC (permalink / raw)
To: Larry Finger
Cc: Chaoming Li, John W. Linville, linux-wireless, netdev,
linux-kernel
On Sat, 2012-03-17 at 16:14 -0500, Larry Finger wrote:
> Is there a PATCH 2/2? I did not receive it.
Yes.
It's a line continuation removal patch to other files.
https://lkml.org/lkml/2012/3/17/72
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] rtlwifi: Use is_zero_ether_addr, remove line continuation
2012-03-17 21:14 ` Larry Finger
2012-03-17 21:18 ` Joe Perches
@ 2012-03-17 21:18 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2012-03-17 21:18 UTC (permalink / raw)
To: Larry.Finger
Cc: joe, chaoming_li, linville, linux-wireless, netdev, linux-kernel
From: Larry Finger <Larry.Finger@lwfinger.net>
Date: Sat, 17 Mar 2012 16:14:53 -0500
> On 03/17/2012 02:13 PM, Joe Perches wrote:
>> Use the normal kernel facilities and use %pM
>> to print the all zero mac address.
>>
>> Remove unnecessary line continuation.
>>
>> Signed-off-by: Joe Perches<joe@perches.com>
>> ---
>> drivers/net/wireless/rtlwifi/cam.c | 5 ++---
>> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> ACKed-by: Larry.Finger@lwfinger.net
>
> Is there a PATCH 2/2? I did not receive it.
It went to netdev only and was only for non-wireless networking
drivers.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-17 21:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-17 19:13 [PATCH 1/2] rtlwifi: Use is_zero_ether_addr, remove line continuation Joe Perches
2012-03-17 21:14 ` Larry Finger
2012-03-17 21:18 ` Joe Perches
2012-03-17 21:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).