* [PATCH] rt2x00: rt2800usb: fix status register reread logic
@ 2012-03-19 14:59 Stanislaw Gruszka
2012-03-20 4:11 ` Gertjan van Wingerde
0 siblings, 1 reply; 2+ messages in thread
From: Stanislaw Gruszka @ 2012-03-19 14:59 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, users, Jakub Kicinski, Stanislaw Gruszka
Another good catch from Jakub Kicinski. This patch fixes my
recent commit: ed61e2b02027935520d1be884fac0b2ffce8379a
"rt2x00: rt2800usb: rework txdone code"
We should reread status register only when nobody else start already
reading status i.e. test_and_set_bit(TX_STATUS_READING, flags) return 0.
Reported-by: Jakub Kicinski <moorray@wp.pl>
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/net/wireless/rt2x00/rt2800usb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
index f97f846..001735f 100644
--- a/drivers/net/wireless/rt2x00/rt2800usb.c
+++ b/drivers/net/wireless/rt2x00/rt2800usb.c
@@ -184,7 +184,7 @@ stop_reading:
* here again if status reading is needed.
*/
if (rt2800usb_txstatus_pending(rt2x00dev) &&
- test_and_set_bit(TX_STATUS_READING, &rt2x00dev->flags))
+ !test_and_set_bit(TX_STATUS_READING, &rt2x00dev->flags))
return true;
else
return false;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rt2x00: rt2800usb: fix status register reread logic
2012-03-19 14:59 [PATCH] rt2x00: rt2800usb: fix status register reread logic Stanislaw Gruszka
@ 2012-03-20 4:11 ` Gertjan van Wingerde
0 siblings, 0 replies; 2+ messages in thread
From: Gertjan van Wingerde @ 2012-03-20 4:11 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: John W. Linville, linux-wireless, users, Jakub Kicinski
On 03/19/12 15:59, Stanislaw Gruszka wrote:
> Another good catch from Jakub Kicinski. This patch fixes my
> recent commit: ed61e2b02027935520d1be884fac0b2ffce8379a
> "rt2x00: rt2800usb: rework txdone code"
>
> We should reread status register only when nobody else start already
> reading status i.e. test_and_set_bit(TX_STATUS_READING, flags) return 0.
>
> Reported-by: Jakub Kicinski <moorray@wp.pl>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2800usb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
> index f97f846..001735f 100644
> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
> @@ -184,7 +184,7 @@ stop_reading:
> * here again if status reading is needed.
> */
> if (rt2800usb_txstatus_pending(rt2x00dev) &&
> - test_and_set_bit(TX_STATUS_READING, &rt2x00dev->flags))
> + !test_and_set_bit(TX_STATUS_READING, &rt2x00dev->flags))
> return true;
> else
> return false;
--
---
Gertjan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-20 4:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-19 14:59 [PATCH] rt2x00: rt2800usb: fix status register reread logic Stanislaw Gruszka
2012-03-20 4:11 ` Gertjan van Wingerde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).