From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, <ath6kl-devel@qualcomm.com>
Subject: Re: [PATCH] ath6kl: Dump htc header when invalid Rx frame length is detected
Date: Wed, 21 Mar 2012 11:14:59 +0200 [thread overview]
Message-ID: <4F699C13.4030806@qca.qualcomm.com> (raw)
In-Reply-To: <1332321107-25671-1-git-send-email-vthiagar@qca.qualcomm.com>
On 03/21/2012 11:11 AM, Vasanthakumar Thiagarajan wrote:
> Dump htc header along with the warning message when the request
> to Rx with invalid frame length is detected.
>
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
[...]
> - ath6kl_warn("Rx buffer requested with invalid length\n");
> + ath6kl_warn("Rx buffer requested with invalid length"
> + "htc_hdr:eid - %d, flags - 0x%x, len - %d\n",
No need to split the format string, that's an exception to the long line
rule. Also please minimise the message a bit:
"Rx buffer requested with invalid length htc_hdr: eid %d flags 0x%x len
%d\n"
I try to keep the log messages as small as possible so that they are
easier to read.
Kalle
prev parent reply other threads:[~2012-03-21 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 9:11 [PATCH] ath6kl: Dump htc header when invalid Rx frame length is detected Vasanthakumar Thiagarajan
2012-03-21 9:14 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F699C13.4030806@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).