* [PATCH] ath6kl: Dump htc header when invalid Rx frame length is detected
@ 2012-03-21 9:11 Vasanthakumar Thiagarajan
2012-03-21 9:14 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Vasanthakumar Thiagarajan @ 2012-03-21 9:11 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, ath6kl-devel
Dump htc header along with the warning message when the request
to Rx with invalid frame length is detected.
Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath6kl/htc.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/htc.c b/drivers/net/wireless/ath/ath6kl/htc.c
index 4849d99..e6ec28b 100644
--- a/drivers/net/wireless/ath/ath6kl/htc.c
+++ b/drivers/net/wireless/ath/ath6kl/htc.c
@@ -1353,7 +1353,10 @@ static int ath6kl_htc_rx_setup(struct htc_target *target,
sizeof(*htc_hdr));
if (!htc_valid_rx_frame_len(target, ep->eid, full_len)) {
- ath6kl_warn("Rx buffer requested with invalid length\n");
+ ath6kl_warn("Rx buffer requested with invalid length"
+ "htc_hdr:eid - %d, flags - 0x%x, len - %d\n",
+ htc_hdr->eid, htc_hdr->flags,
+ le16_to_cpu(htc_hdr->payld_len));
return -EINVAL;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath6kl: Dump htc header when invalid Rx frame length is detected
2012-03-21 9:11 [PATCH] ath6kl: Dump htc header when invalid Rx frame length is detected Vasanthakumar Thiagarajan
@ 2012-03-21 9:14 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2012-03-21 9:14 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan; +Cc: linux-wireless, ath6kl-devel
On 03/21/2012 11:11 AM, Vasanthakumar Thiagarajan wrote:
> Dump htc header along with the warning message when the request
> to Rx with invalid frame length is detected.
>
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
[...]
> - ath6kl_warn("Rx buffer requested with invalid length\n");
> + ath6kl_warn("Rx buffer requested with invalid length"
> + "htc_hdr:eid - %d, flags - 0x%x, len - %d\n",
No need to split the format string, that's an exception to the long line
rule. Also please minimise the message a bit:
"Rx buffer requested with invalid length htc_hdr: eid %d flags 0x%x len
%d\n"
I try to keep the log messages as small as possible so that they are
easier to read.
Kalle
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-21 9:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-21 9:11 [PATCH] ath6kl: Dump htc header when invalid Rx frame length is detected Vasanthakumar Thiagarajan
2012-03-21 9:14 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).