From: Larry Finger <Larry.Finger@lwfinger.net>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: jerome huang <jerome.syno@gmail.com>,
"Xu, Andiry" <Andiry.Xu@amd.com>,
linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: rt8192cu on USB3
Date: Fri, 23 Mar 2012 23:55:23 -0500 [thread overview]
Message-ID: <4F6D53BB.90203@lwfinger.net> (raw)
In-Reply-To: <20120323203404.GD5207@xanatos>
On 03/23/2012 03:34 PM, Sarah Sharp wrote:
> On Thu, Mar 22, 2012 at 09:24:31PM -0500, Larry Finger wrote:
>> On 03/22/2012 05:31 PM, Sarah Sharp wrote:
>>
>>> Larry, if the driver doesn't cancel an URB that the device doesn't
>>> respond to, then it will just be left on the endpoint ring. If the
>>> driver then tries to queue new transfers to that same endpoint, but the
>>> device keeps NAKing the uncancelled transfer, then the endpoint ring
>>> would fill up with unanswered transfers.
>>>
>>> Perhaps some userspace or kernel portion is forgetting to cancel URBs
>>> before moving onto the next thing? You said you moved to asynchronous
>>> transfers, so maybe the problem lies there?
>>
>> The writes have always been asynchronous and reads are synchronous.
>> The only change was to convert the firmware uploading writes from
>> 32-bits at a time into block writes of 1000+ 32-bit words.
>
> Yeah, that's going to cause the out-of-room warning under xHCI. That
> should be fixed in the 3.4-rc1 kernel though.
>
>> Would xhci be worse that ohci or ehci in terms of the device not
>> responding to URBs? We only see problems with USB3.0 hubs, never
>> with 2.0 or 1.1.
>
> That's because EHCI handles arbitrarily large transfers, and xHCI didn't
> until now.
>
>> I am looking into changing the writes to be synchronous. That should
>> clear up any problems.
>
> Yeah, your problem probably was in the bulk large transfer, not the
> unfinished canceled URBs. I would suggest getting your reporters to
> just try 3.4-rc1 and see if it helps before doing too much work to debug
> this.
Interesting in that I switched to the large bulk transfers AFTER the problems
with xHCI were reported. I guess my attempts to fix the problem only made it worse.
Larry
prev parent reply other threads:[~2012-03-24 4:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 2:03 rt8192cu on USB3 jerome huang
2012-03-08 2:16 ` jerome huang
2012-03-08 2:35 ` Larry Finger
2012-03-08 6:35 ` jerome huang
2012-03-08 7:06 ` Andiry Xu
2012-03-08 7:11 ` Andiry Xu
[not found] ` <2A76B9D36150BE4293842BC2FE8FF165016A31@SCYBEXDAG04.amd.com>
2012-03-08 10:32 ` jerome huang
2012-03-08 11:26 ` jerome huang
2012-03-08 17:56 ` Larry Finger
2012-03-09 3:28 ` jerome huang
2012-03-09 3:59 ` Larry Finger
2012-03-09 7:39 ` jerome huang
2012-03-09 15:04 ` Larry Finger
2012-03-09 16:02 ` jerome huang
2012-03-22 22:31 ` Sarah Sharp
2012-03-23 2:24 ` Larry Finger
2012-03-23 20:34 ` Sarah Sharp
2012-03-24 2:16 ` Richard Farina
2012-03-24 4:59 ` Larry Finger
2012-04-05 22:49 ` Sarah Sharp
2012-03-24 4:55 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6D53BB.90203@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Andiry.Xu@amd.com \
--cc=jerome.syno@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).