Re: [PATCH] ath9k: Don't delete key from hw if using sw-crypt.

[Felix Fietkau <nbd@openwrt.org>]

On 2012-04-02 10:41 PM, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> This spams logs if we are using large numbers of stations,
> for instance:
> 
> ath: wiphy0: keyreset: keycache entry 228 out of range
> ath: wiphy0: keyreset: keycache entry 228 out of range
> 
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
> :100644 100644 917032a... 65e7281... M	drivers/net/wireless/ath/ath9k/main.c
>  drivers/net/wireless/ath/ath9k/main.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
> index 917032a..65e7281 100644
> --- a/drivers/net/wireless/ath/ath9k/main.c
> +++ b/drivers/net/wireless/ath/ath9k/main.c
> @@ -1771,6 +1771,9 @@ static void ath9k_del_ps_key(struct ath_softc *sc,
>  	if (!an->ps_key)
>  	    return;
>  
> +	if (ath9k_modparam_nohwcrypt)
> +		return;
> +
This looks wrong to me. ps_key is used for better powersave handling of
both unencrypted and encrypted stations (using the keycache only for tx
filtering on unencrypted stations).

- Felix