From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vivek Natarajan <nataraja@qca.qualcomm.com>,
<ath6kl-devel@qualcomm.com>, <linux-wireless@vger.kernel.org>,
PingYang Zhang <pingzhan@qca.qualcomm.com>
Subject: Re: [PATCH 1/2] ath6kl: Use vmalloc instead of kmalloc for fw
Date: Tue, 3 Apr 2012 21:47:29 +0300 [thread overview]
Message-ID: <4F7B45C1.3030804@qca.qualcomm.com> (raw)
In-Reply-To: <1333478499.26079.67.camel@joe2Laptop>
On 04/03/2012 09:41 PM, Joe Perches wrote:
> On Tue, 2012-04-03 at 21:27 +0300, Kalle Valo wrote:
>> On 03/28/2012 04:51 PM, Vivek Natarajan wrote:
>>> Sometimes it has been observed that allocating a contiguous memory
>>> of more than 100K fails with kmalloc. This has been modified to
>>> use vmalloc instead.
>>>
>>> Signed-off-by: PingYang Zhang <pingzhan@qca.qualcomm.com>
>>> Signed-off-by: Vivek Natarajan <nataraja@qca.qualcomm.com>
>>
>> Thanks, both patches applied.
>
> Because the vmalloc space is limited, this should try
> kmalloc first and only on failure try vmalloc.
Thanks, I didn't know that.
Vivek, I would gladly take a followup patch which does what Joe suggests.
Kalle
prev parent reply other threads:[~2012-04-03 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 13:51 [PATCH 1/2] ath6kl: Use vmalloc instead of kmalloc for fw Vivek Natarajan
2012-03-28 13:51 ` [PATCH 2/2] ath6kl: Fix scan related issue on suspend-resume Vivek Natarajan
2012-04-03 18:27 ` [PATCH 1/2] ath6kl: Use vmalloc instead of kmalloc for fw Kalle Valo
2012-04-03 18:41 ` Joe Perches
2012-04-03 18:47 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7B45C1.3030804@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=akpm@linux-foundation.org \
--cc=ath6kl-devel@qualcomm.com \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nataraja@qca.qualcomm.com \
--cc=pingzhan@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).