From: Felix Fietkau <nbd@openwrt.org>
To: Ben Greear <greearb@candelatech.com>
Cc: Felix Fietkau <nbd@nbd.name>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath9k: Don't delete key from hw if using sw-crypt.
Date: Wed, 04 Apr 2012 13:56:06 +0200 [thread overview]
Message-ID: <4F7C36D6.1040202@openwrt.org> (raw)
In-Reply-To: <4F7B20B0.6030107@candelatech.com>
On 2012-04-03 6:09 PM, Ben Greear wrote:
> On 04/03/2012 09:05 AM, Felix Fietkau wrote:
>>
>> On 03.04.2012, at 16:44, Ben Greear<greearb@candelatech.com> wrote:
>>
>>> On 04/03/2012 06:16 AM, Felix Fietkau wrote:
>>>> On 2012-04-02 10:41 PM, greearb@candelatech.com wrote:
>>>>> From: Ben Greear<greearb@candelatech.com>
>>>>>
>>>>> This spams logs if we are using large numbers of stations,
>>>>> for instance:
>>>>>
>>>>> ath: wiphy0: keyreset: keycache entry 228 out of range
>>>>> ath: wiphy0: keyreset: keycache entry 228 out of range
>>>>>
>>>>> Signed-off-by: Ben Greear<greearb@candelatech.com>
>>>>> ---
>>>>> :100644 100644 917032a... 65e7281... M drivers/net/wireless/ath/ath9k/main.c
>>>>> drivers/net/wireless/ath/ath9k/main.c | 3 +++
>>>>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>>>>
>>>>> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
>>>>> index 917032a..65e7281 100644
>>>>> --- a/drivers/net/wireless/ath/ath9k/main.c
>>>>> +++ b/drivers/net/wireless/ath/ath9k/main.c
>>>>> @@ -1771,6 +1771,9 @@ static void ath9k_del_ps_key(struct ath_softc *sc,
>>>>> if (!an->ps_key)
>>>>> return;
>>>>>
>>>>> + if (ath9k_modparam_nohwcrypt)
>>>>> + return;
>>>>> +
>>>> This looks wrong to me. ps_key is used for better powersave handling of
>>>> both unencrypted and encrypted stations (using the keycache only for tx
>>>> filtering on unencrypted stations).
>>>
>>> Ok..should we just remove the spammy printk when the keycache entry
>>> is out of range then?
>> I'd say we should figure out why it triggers at all.
>
> I have more than 200 stations associating, and that is more than there
> are key-indexes it appears. I can add a WARN_ON if you'd like to see
> a backtrace or any other info...
In that case key index allocation should simply fail instead of
returning something that it refuses to delete later.
- Felix
prev parent reply other threads:[~2012-04-04 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 20:41 [PATCH] ath9k: Don't delete key from hw if using sw-crypt greearb
2012-04-03 13:16 ` Felix Fietkau
2012-04-03 14:44 ` Ben Greear
2012-04-03 16:05 ` Felix Fietkau
2012-04-03 16:09 ` Ben Greear
2012-04-04 11:56 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7C36D6.1040202@openwrt.org \
--to=nbd@openwrt.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).