From: Tim Gardner <tim.gardner@canonical.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: "Luis R. Rodriguez" <mcgrof@frijolero.org>,
hauke@hauke-m.de,
"Luis R. Rodriguez" <mcgrof@bombadil.infradead.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@lists.ubuntu.com,
lf_driver_backport@lists.linux-foundation.org,
tim.gardner@canonical.com
Subject: Re: [PATCH] compat: add compat kernel checker and downloader
Date: Thu, 05 Apr 2012 14:19:21 -0600 [thread overview]
Message-ID: <4F7DFE49.9040004@canonical.com> (raw)
In-Reply-To: <20120404111014.GB3378@shadowen.org>
On 04/04/2012 05:10 AM, Andy Whitcroft wrote:
> On Fri, Mar 30, 2012 at 05:23:46PM -0700, Luis R. Rodriguez wrote:
>> Andy, so I just noticed that on all Ubuntu PPA (and generic) kernels
>> you guys have a broken symlink >= 2.6.33.
>>
>> /lib/modules/2.6.33-02063305-generic/build/include/asm
>>
>> points to asm-x86 and that is no longer present after 2.6.33 so any
>> module requiring those header files will break now on Ubuntu. I just
>> spotted this as some file from asm is now included in the modules were
>> are building. I guess not many external kernel modules include asm dir
>> otherwise you guys would have noticed this a long time ago.
>
> Luis, I concur that the link is now broken. However that link is actually
> simply superfulous now. Anything correctly using kernel 'external
> module' support will be using the -I path from the kernel Makefiles.
> They will therefore be including from /usr/src/<version>/include _and_
> /usr/src/<version>/arch/x86/include. I presume this is why we have not
> noticed it.
>
> I will get that link removed however as it is simply bogus.
>
> -apw
>
I just corrected the invalid link so that it points at asm-generic.
http://bugs.launchpad.net/bugs/974403
rtg
--
Tim Gardner tim.gardner@canonical.com
prev parent reply other threads:[~2012-04-05 20:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 23:43 [PATCH] compat: add compat kernel checker and downloader Luis R. Rodriguez
2012-02-06 10:57 ` Andy Whitcroft
2012-02-06 16:07 ` John W. Linville
2012-02-07 4:19 ` Luis R. Rodriguez
2012-02-07 4:56 ` Luis R. Rodriguez
2012-02-08 1:19 ` Luis R. Rodriguez
2012-02-08 2:55 ` Luis R. Rodriguez
2012-02-08 2:58 ` Luis R. Rodriguez
2012-03-31 0:23 ` Luis R. Rodriguez
2012-04-04 11:10 ` Andy Whitcroft
2012-04-05 20:19 ` Tim Gardner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7DFE49.9040004@canonical.com \
--to=tim.gardner@canonical.com \
--cc=apw@canonical.com \
--cc=hauke@hauke-m.de \
--cc=kernel-team@lists.ubuntu.com \
--cc=lf_driver_backport@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@bombadil.infradead.org \
--cc=mcgrof@frijolero.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).