Re: [PATCH 2/2] ath6kl: Configure htcap in fw based on the channel type in AP mode

[Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>]

On Friday 06 April 2012 08:24 PM, Joe Perches wrote:
> On Fri, 2012-04-06 at 19:37 +0530, Vasanthakumar Thiagarajan wrote:
>> This patch disables HT in start_ap if the type of the channel on
>> which the AP mode is going to be operating is non-HT. HT is enabled
>> with default ht cap setting if the operating channel is going to be
>> 11n.
> []
>> diff --git a/drivers/net/wireless/ath/ath6kl/core.h b/drivers/net/wireless/ath/ath6kl/core.h
> []
>> @@ -477,6 +477,12 @@ struct ath6kl_mc_filter {
>>   	char hw_addr[ATH6KL_MCAST_FILTER_MAC_ADDR_SIZE];
>>   };
>>
>> +struct ath6kl_htcap {
>> +	bool ht_enable;
>> +	unsigned short cap_info;
>> +	u8 ampdu_factor;
>> +};
>
> Probably better to rearrange this as:
>
> struct ath6kl_htcap {
> 	unsigned short cap_info;
> 	u8 ampdu_factor;
> 	bool ht_enable;
> };

You are right, there are couple bytes getting padded, i'll address this. 
Thanks for reviewing!

Vasanth