From: Larry Finger <Larry.Finger@lwfinger.net>
To: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
Cc: John Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: ID for Belkin Surf N300 XR
Date: Sun, 08 Apr 2012 11:46:12 -0500 [thread overview]
Message-ID: <4F81C0D4.2090004@lwfinger.net> (raw)
In-Reply-To: <CAA2SeN+7FsyQKmCK62tzEzrHLVi6-H21wZ+bdTjS2rLDDdauCA@mail.gmail.com>
On 04/08/2012 11:00 AM, Lorenzo Bianconi wrote:
> Hi,
>
> I added ID for Belkin Surf N300 XR wireless usb adapter to rtlwifi driver.
>
> Regards
>
> Lorenzo
>
> Signed-off-by: Lorenzo Bianconi<lorenzo.bianconi83@gmail.com>
> ---
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
> @@ -340,6 +340,7 @@
> /****** 8192CU ********/
> {RTL_USB_DEVICE(0x050d, 0x2102, rtl92cu_hal_cfg)}, /*Belcom-Sercomm*/
> {RTL_USB_DEVICE(0x050d, 0x2103, rtl92cu_hal_cfg)}, /*Belcom-Edimax*/
> + {RTL_USB_DEVICE(0x050d, 0x1004, rtl92cu_hal_cfg)}, /*Belkin-SurfN300*/
> {RTL_USB_DEVICE(0x0586, 0x341f, rtl92cu_hal_cfg)}, /*Zyxel -Abocom*/
> {RTL_USB_DEVICE(0x07aa, 0x0056, rtl92cu_hal_cfg)}, /*ATKK-Gemtek*/
> {RTL_USB_DEVICE(0x07b8, 0x8178, rtl92cu_hal_cfg)}, /*Funai -Abocom*/
Thanks for the patch, but I have some comments.
Anything you state above the first --- delimiter ends up in the permanent commit
message in the kernel. I doubt that you wanted your little note to be in that
category.
I try to keep the USB IDs sorted by device type, and in numerical order within a
type. Are you sure your device is an 8192CU, and not an 8188CU? Belcom has used
both. Is the one you have an F7D2101? Does 'lsusb' say anything about what chip
is used?
Larry
next prev parent reply other threads:[~2012-04-08 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-08 16:00 [PATCH] rtlwifi: ID for Belkin Surf N300 XR Lorenzo Bianconi
2012-04-08 16:46 ` Larry Finger [this message]
2012-04-08 17:37 ` Lorenzo Bianconi
2012-04-08 17:52 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F81C0D4.2090004@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lorenzo.bianconi83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).