From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:64135 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751861Ab2DLHc7 (ORCPT ); Thu, 12 Apr 2012 03:32:59 -0400 Message-ID: <4F868526.5020703@qca.qualcomm.com> (sfid-20120412_093301_811924_14F54B18) Date: Thu, 12 Apr 2012 10:32:54 +0300 From: Kalle Valo MIME-Version: 1.0 To: Joe Perches CC: linux-wireless Subject: Re: Checkpatch warnings with pr_fmt() References: <4F868445.1030209@qca.qualcomm.com> In-Reply-To: <4F868445.1030209@qca.qualcomm.com> Content-Type: text/plain; charset="ISO-8859-1" Sender: linux-wireless-owner@vger.kernel.org List-ID: On 04/12/2012 10:29 AM, Kalle Valo wrote: > Hi Joe, > > due to checkpatch warnings in ath6kl, from a recent pr_fmt() addition, I > had to update checkpatch and now I get lots of useless warnings like this: > > drivers/net/wireless/ath/ath6kl/common.h:28: CHECK: Don't begin block > comments with only a /* line, use /* comment... > drivers/net/wireless/ath/ath6kl/bmi.h:233: CHECK: No space is necessary > after a cast > > IMHO they are wrong, at least the style I have tried to enforce in > ath6kl is totally opposite (I have "/*\n" on multiline comments and a > space after a cast). And at least CodingStyle seems to recommend my > style for the multiline comments. > > Would you consider removing these two warnings? Or maybe add a new check > level so that I can easily disable them? > > As I get a lot of patches from people not familiar with the Linux coding > style checkpatch is a valuable tool for me, I cannot spot all the style > issues by just reviewing the patches. But now checkpatch is useless for > me as the real warnings get buried within the noise. Forgot to mention that for now I just reverted commit aad4f614983 ("checkpatch: add --strict tests for braces, comments and casts") and checkpatch is usable again. But I hope we find a proper solution for this. Kalle