Re: [PATCH] cfg80211: fix interface combinations check.

[Lukasz Kucharczyk <lukasz.kucharczyk@tieto.com>]

On 04/12/2012 06:27 AM, Johannes Berg wrote:
> On Wed, 2012-04-11 at 14:55 +0200, Lukasz Kucharczyk wrote:
>> Signed-off-by: Lukasz Kucharczyk<lukasz.kucharczyk@tieto.com>
>
> Good catch, should this be Cc stable?

I think so, but I have only tested this with driver which is not yet 
upstreamed. It seems that only carl9170 and iwlwifi are using interface 
combinations. Christian, Wey, what do you think?

Lukasz

>
>> ---
>>   net/wireless/util.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/wireless/util.c b/net/wireless/util.c
>> index 1b7a08d..957f256 100644
>> --- a/net/wireless/util.c
>> +++ b/net/wireless/util.c
>> @@ -989,7 +989,7 @@ int cfg80211_can_change_interface(struct cfg80211_registered_device *rdev,
>>   			if (rdev->wiphy.software_iftypes&  BIT(iftype))
>>   				continue;
>>   			for (j = 0; j<  c->n_limits; j++) {
>> -				if (!(limits[j].types&  iftype))
>> +				if (!(limits[j].types&  BIT(iftype)))
>>   					continue;
>>   				if (limits[j].max<  num[iftype])
>>   					goto cont;
>
>