* [PATCH] cfg80211: fix interface combinations check.
@ 2012-04-11 12:55 Lukasz Kucharczyk
2012-04-12 4:27 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Lukasz Kucharczyk @ 2012-04-11 12:55 UTC (permalink / raw)
To: linux-wireless; +Cc: johannes, lukasz.kucharczyk
Signed-off-by: Lukasz Kucharczyk <lukasz.kucharczyk@tieto.com>
---
net/wireless/util.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/wireless/util.c b/net/wireless/util.c
index 1b7a08d..957f256 100644
--- a/net/wireless/util.c
+++ b/net/wireless/util.c
@@ -989,7 +989,7 @@ int cfg80211_can_change_interface(struct cfg80211_registered_device *rdev,
if (rdev->wiphy.software_iftypes & BIT(iftype))
continue;
for (j = 0; j < c->n_limits; j++) {
- if (!(limits[j].types & iftype))
+ if (!(limits[j].types & BIT(iftype)))
continue;
if (limits[j].max < num[iftype])
goto cont;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cfg80211: fix interface combinations check.
2012-04-11 12:55 [PATCH] cfg80211: fix interface combinations check Lukasz Kucharczyk
@ 2012-04-12 4:27 ` Johannes Berg
2012-04-12 7:57 ` Lukasz Kucharczyk
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2012-04-12 4:27 UTC (permalink / raw)
To: Lukasz Kucharczyk; +Cc: linux-wireless
On Wed, 2012-04-11 at 14:55 +0200, Lukasz Kucharczyk wrote:
> Signed-off-by: Lukasz Kucharczyk <lukasz.kucharczyk@tieto.com>
Good catch, should this be Cc stable?
johannes
> ---
> net/wireless/util.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/wireless/util.c b/net/wireless/util.c
> index 1b7a08d..957f256 100644
> --- a/net/wireless/util.c
> +++ b/net/wireless/util.c
> @@ -989,7 +989,7 @@ int cfg80211_can_change_interface(struct cfg80211_registered_device *rdev,
> if (rdev->wiphy.software_iftypes & BIT(iftype))
> continue;
> for (j = 0; j < c->n_limits; j++) {
> - if (!(limits[j].types & iftype))
> + if (!(limits[j].types & BIT(iftype)))
> continue;
> if (limits[j].max < num[iftype])
> goto cont;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cfg80211: fix interface combinations check.
2012-04-12 4:27 ` Johannes Berg
@ 2012-04-12 7:57 ` Lukasz Kucharczyk
0 siblings, 0 replies; 3+ messages in thread
From: Lukasz Kucharczyk @ 2012-04-12 7:57 UTC (permalink / raw)
To: Johannes Berg, chunkeey, wey-yi.w.guy; +Cc: linux-wireless@vger.kernel.org
On 04/12/2012 06:27 AM, Johannes Berg wrote:
> On Wed, 2012-04-11 at 14:55 +0200, Lukasz Kucharczyk wrote:
>> Signed-off-by: Lukasz Kucharczyk<lukasz.kucharczyk@tieto.com>
>
> Good catch, should this be Cc stable?
I think so, but I have only tested this with driver which is not yet
upstreamed. It seems that only carl9170 and iwlwifi are using interface
combinations. Christian, Wey, what do you think?
Lukasz
>
>> ---
>> net/wireless/util.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/wireless/util.c b/net/wireless/util.c
>> index 1b7a08d..957f256 100644
>> --- a/net/wireless/util.c
>> +++ b/net/wireless/util.c
>> @@ -989,7 +989,7 @@ int cfg80211_can_change_interface(struct cfg80211_registered_device *rdev,
>> if (rdev->wiphy.software_iftypes& BIT(iftype))
>> continue;
>> for (j = 0; j< c->n_limits; j++) {
>> - if (!(limits[j].types& iftype))
>> + if (!(limits[j].types& BIT(iftype)))
>> continue;
>> if (limits[j].max< num[iftype])
>> goto cont;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-12 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-11 12:55 [PATCH] cfg80211: fix interface combinations check Lukasz Kucharczyk
2012-04-12 4:27 ` Johannes Berg
2012-04-12 7:57 ` Lukasz Kucharczyk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).