From: Larry Finger <Larry.Finger@lwfinger.net>
To: Xose Vazquez Perez <xose.vazquez@gmail.com>
Cc: linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
IvDoorn@gmail.com, linville@tuxdriver.com, gwingerde@gmail.com,
helmut.schaa@googlemail.com
Subject: Re: [PATCH] wireless: rt2x00: rt{2500,73}usb.c put back duplicate id
Date: Sat, 14 Apr 2012 16:36:12 -0500 [thread overview]
Message-ID: <4F89EDCC.7080302@lwfinger.net> (raw)
In-Reply-To: <1334437201-12737-1-git-send-email-xose.vazquez@gmail.com>
On 04/14/2012 04:00 PM, Xose Vazquez Perez wrote:
> put back 0x050d,0x7050 to rt73usb, same usb_id for two chips:
>
> K7SF5D7050A ver 2xxx is rt2500
> K7SF5D7050B ver 3xxx is rt73
>
> <http://en-us-support.belkin.com/app/answers/detail/a_id/297/kw/K7SF5D7050>
>
> Signed-off-by: Xose Vazquez Perez<xose.vazquez@gmail.com>
I did a quick look at the rt2500 driver and did not see any code that detects
what version chip is being read. If it is possible to determine if it is ver
2xxx and not 3xxx, then the probe routine should do that and return an error if
the wrong driver is being loaded. A similar situation arises in the Realtek PCI
devices. In that case, it is a PCI revision that allows a driver to reject the
wrong hardware.
Larry
next prev parent reply other threads:[~2012-04-14 21:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 21:00 [PATCH] wireless: rt2x00: rt{2500,73}usb.c put back duplicate id Xose Vazquez Perez
2012-04-14 21:36 ` Larry Finger [this message]
2012-04-17 15:13 ` Xose Vazquez Perez
2012-04-17 15:43 ` Larry Finger
2012-12-13 15:50 ` Xose Vazquez Perez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F89EDCC.7080302@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=IvDoorn@gmail.com \
--cc=gwingerde@gmail.com \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).