From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Robert Love <rlove@google.com>,
"John W. Linville" <linville@tuxdriver.com>,
ath6kl-devel <ath6kl-devel@qualcomm.com>
Subject: Re: [PATCH] ath6kl: fix memory leak in ath6kl_fwlog_block_read()
Date: Mon, 16 Apr 2012 09:07:49 +0300 [thread overview]
Message-ID: <4F8BB735.4040409@qca.qualcomm.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1204112239070.2137@swampdragon.chaosbits.net>
On 04/11/2012 11:41 PM, Jesper Juhl wrote:
> If, in
> drivers/net/wireless/ath/ath6kl/debug.c::ath6kl_fwlog_block_read(),
> the call to wait_for_completion_interruptible() returns -ERESTARTSYS
> then we'll return without freeing the (as yet unused) memory we
> allocated for 'buf' - thus leaking it.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Thanks, applied to ath6kl.git.
Kalle
prev parent reply other threads:[~2012-04-16 6:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 20:41 [PATCH] ath6kl: fix memory leak in ath6kl_fwlog_block_read() Jesper Juhl
2012-04-16 6:07 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8BB735.4040409@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=rlove@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).