From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
<linux-wireless@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>,
ath6kl-devel <ath6kl-devel@qualcomm.com>
Subject: Re: [patch] ath6kl: list_first_entry() is never NULL
Date: Mon, 16 Apr 2012 09:27:38 +0300 [thread overview]
Message-ID: <4F8BBBDA.9030502@qca.qualcomm.com> (raw)
In-Reply-To: <20120413192718.GD18505@elgon.mountain>
On 04/13/2012 10:27 PM, Dan Carpenter wrote:
> We can remove the NULL check here. It triggers a Smatch warning because
> list_first_entry() never is NULL and people who check for it normally
> intend to check for list_empty() instead. In these cases however,
> we've already verified that the lists are not empty.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied to ath6kl.git.
Kalle
prev parent reply other threads:[~2012-04-16 6:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 19:27 [patch] ath6kl: list_first_entry() is never NULL Dan Carpenter
2012-04-16 6:27 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8BBBDA.9030502@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).