linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@openwrt.org>
To: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
	rodrigue@qca.qualcomm.com
Subject: Re: [PATCH v2 7/8] ath9k_hw: disable fast channel change when changing from/to half/quarter mode
Date: Tue, 17 Apr 2012 13:06:16 +0200	[thread overview]
Message-ID: <4F8D4EA8.1010602@openwrt.org> (raw)
In-Reply-To: <20364.60189.208919.748818@gargle.gargle.HOWL>

On 2012-04-17 6:01 AM, Sujith Manoharan wrote:
> Felix Fietkau wrote:
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>> ---
>>  drivers/net/wireless/ath/ath9k/hw.c |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>> 
>> diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
>> index ff8d58d..26e6083 100644
>> --- a/drivers/net/wireless/ath/ath9k/hw.c
>> +++ b/drivers/net/wireless/ath/ath9k/hw.c
>> @@ -1440,6 +1440,10 @@ static bool ath9k_hw_channel_change(struct ath_hw *ah,
>>  						    CHANNEL_5GHZ));
>>  	mode_diff = (chan->chanmode != ah->curchan->chanmode);
>>  
>> +	if ((ah->curchan->channelFlags | chan->channelFlags) &
>> +	    (CHANNEL_HALF | CHANNEL_QUARTER))
>> +		return false;
>> +
> 
> ath9k_hw_do_fastcc() is a better place where this check can be done.
OK, will send a v3.

- Felix

      reply	other threads:[~2012-04-17 11:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16 21:09 [PATCH v2 1/8] ath9k_hw: use standard SIFS time as reference for half/quarter channels Felix Fietkau
2012-04-16 21:09 ` [PATCH v2 2/8] ath9k_hw: increase ACK timeout " Felix Fietkau
2012-04-16 21:09   ` [PATCH v2 3/8] ath9k_hw: set the PHY mode for half/quarter channels on AR9003 Felix Fietkau
2012-04-16 21:09     ` [PATCH v2 4/8] ath9k_hw: increase symbol overlap window for half/quarter channels Felix Fietkau
2012-04-16 21:09       ` [PATCH v2 5/8] ath9k_hw: fix and clean up PHY activation delay Felix Fietkau
2012-04-16 21:09         ` [PATCH v2 6/8] ath9k_hw: disable Tx IQ calibration on half/quarter channels Felix Fietkau
2012-04-16 21:09           ` [PATCH v2 7/8] ath9k_hw: disable fast channel change when changing from/to half/quarter mode Felix Fietkau
2012-04-16 21:09             ` [PATCH v2 8/8] ath9k_hw: increase tx abort timeout for half/quarter channels Felix Fietkau
2012-04-17  4:01             ` [PATCH v2 7/8] ath9k_hw: disable fast channel change when changing from/to half/quarter mode Sujith Manoharan
2012-04-17 11:06               ` Felix Fietkau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8D4EA8.1010602@openwrt.org \
    --to=nbd@openwrt.org \
    --cc=c_manoha@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=rodrigue@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).