From: Gabor Juhos <juhosg@openwrt.org>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] ath9k: Gather and report IRQ sync_cause errors.
Date: Tue, 17 Apr 2012 23:29:52 +0200 [thread overview]
Message-ID: <4F8DE0D0.5000701@openwrt.org> (raw)
In-Reply-To: <4F8DDCF1.1080304@candelatech.com>
2012.04.17. 23:13 keltezéssel, Ben Greear írta:
> On 04/17/2012 02:07 PM, Gabor Juhos wrote:
>>> From: Ben Greear<greearb@candelatech.com>
>>>
>>> Report all defined sync_cause errors in debugfs
>>> to aid with debugging.
>>>
>>> Use a macro to print out the interrupts file contents
>>> to decrease code duplication.
>>
>> Now, that the patch is in wireless-testing, I have noticed a minor problem
>> with it.
>
> Thanks for the report.
Np.
> I'll fix this shortly.
Thanks,
Gabor
>
> Thanks,
> Ben
>
>>> +#ifdef CONFIG_ATH9K_DEBUGFS
>>> +void ath9k_debug_sync_cause(struct ath_common *common, u32 sync_cause);
>>> +#else
>>> +static void ath9k_debug_sync_cause(struct ath_common *common, u32
>>> sync_cause) {}
>>
>> Due to a missing 'inline' keyword, this causes a bunch of warnings if
>> CONFIG_ATH9K_DEBUGFS is not enabled:
>>
>> CC [M] drivers/net/wireless/ath/main.o
>> CC [M] drivers/net/wireless/ath/regd.o
>> CC [M] drivers/net/wireless/ath/hw.o
>> CC [M] drivers/net/wireless/ath/key.o
>> LD [M] drivers/net/wireless/ath/ath.o
>> CC [M] drivers/net/wireless/ath/ath9k/beacon.o
>> drivers/net/wireless/ath/ath9k/hw.h:962: warning: ‘ath9k_debug_sync_cause’
>> defined but not used
>
prev parent reply other threads:[~2012-04-17 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 17:03 [PATCH 1/2] ath9k: Use macro to decrease code when priting recv stats greearb
2012-04-12 17:04 ` [PATCH 2/2] ath9k: Gather and report IRQ sync_cause errors greearb
2012-04-17 21:07 ` Gabor Juhos
2012-04-17 21:13 ` Ben Greear
2012-04-17 21:29 ` Gabor Juhos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8DE0D0.5000701@openwrt.org \
--to=juhosg@openwrt.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).