From: Larry Finger <Larry.Finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John W Linville <linville@tuxdriver.com>,
ilw@linux.intel.com, wey-yi.w.guy@intel.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: Fix compile when CONFIG_IWLWIFI_DEBUG is not defined
Date: Tue, 17 Apr 2012 22:05:54 -0500 [thread overview]
Message-ID: <4F8E2F92.7010102@lwfinger.net> (raw)
In-Reply-To: <1334715794.3725.39.camel@jlt3.sipsolutions.net>
On 04/17/2012 09:23 PM, Johannes Berg wrote:
> On Tue, 2012-04-17 at 18:19 -0500, Larry Finger wrote:
>> If CONFIG_IWLWIFI_DEBUG is not defined, the following error results when
>> compiling iwlwifi:
>>
>> CC [M] drivers/net/wireless/iwlwifi/iwl-agn-tt.o
>> In file included from drivers/net/wireless/iwlwifi/iwl-agn-tt.c:40:0:
>> drivers/net/wireless/iwlwifi/iwl-core.h:97:19: error: static declaration of ‘iwl_alloc_traffic_mem’ follows non-static declaration
>> drivers/net/wireless/iwlwifi/iwl-agn.h:513:5: note: previous declaration of ‘iwl_alloc_traffic_mem’ was here
>> make[4]: *** [drivers/net/wireless/iwlwifi/iwl-agn-tt.o] Error 1
>> make[3]: *** [drivers/net/wireless/iwlwifi] Error 2
>> make[2]: *** [drivers/net/wireless] Error 2
>> make[1]: *** [drivers/net] Error 2
>> make: *** [drivers] Error 2
>
> Totally fine with me. We have a pending patch to completely remove that
> functionality though :-)
Until your patch hits the tree, mine will allow everyone to build the driver.
Larry
prev parent reply other threads:[~2012-04-18 3:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 23:19 [PATCH] iwlwifi: Fix compile when CONFIG_IWLWIFI_DEBUG is not defined Larry Finger
2012-04-18 2:23 ` Johannes Berg
2012-04-18 3:05 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8E2F92.7010102@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=ilw@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).