From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 2/6] mac80211: Support getting sta_info stats via ethtool.
Date: Wed, 18 Apr 2012 15:59:00 -0700 [thread overview]
Message-ID: <4F8F4734.7050201@candelatech.com> (raw)
In-Reply-To: <4F8F42B0.8010306@sipsolutions.net>
On 04/18/2012 03:39 PM, Johannes Berg wrote:
> On 4/18/2012 9:27 AM, Ben Greear wrote:
>>> Oh, right, it's adding, I missed that. But is that really useful?
>>
>> It provides a summary for AP, and precise stats for managed station
>> mode (excepting TDLS where it may return sums, it seems).
>
> I just have a feeling that people will rely on it working for managed mode, and will forget about TDLS since it's uncommon now ... so I really don't think this
> will work well with people's (even yours!) expectations.
Ok, how about for managed mode, I will find the first non-TDLS station
matching the netdev, assign the values, and then quit looking for more
stations.
For all other modes, logic stays the same as it is now
(add all stations' stats together as long as the station belongs
to the netdev)?
Thanks,
Ben
>
> johannes
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2012-04-18 22:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 17:46 [PATCH v2 0/6] Add ethtool stats support for Wireless Devices greearb
2012-04-17 17:46 ` [PATCH v2 1/6] cfg80211: Add framework to support ethtool stats greearb
2012-04-17 17:46 ` [PATCH v2 2/6] mac80211: Support getting sta_info stats via ethtool greearb
2012-04-18 1:37 ` Johannes Berg
2012-04-18 3:46 ` Ben Greear
2012-04-18 4:00 ` Johannes Berg
2012-04-18 16:27 ` Ben Greear
2012-04-18 22:39 ` Johannes Berg
2012-04-18 22:59 ` Ben Greear [this message]
2012-04-19 4:38 ` Johannes Berg
2012-04-17 17:46 ` [PATCH v2 3/6] mac80211: Framework to get wifi-driver " greearb
2012-04-17 17:46 ` [PATCH v2 4/6] wireless: Add util method to get channel index from frequency greearb
2012-04-18 1:40 ` Johannes Berg
2012-04-18 3:36 ` Ben Greear
2012-04-17 17:46 ` [PATCH v2 5/6] mac80211: Add more ethtools stats: survey, rates, etc greearb
2012-04-18 1:41 ` Johannes Berg
2012-04-18 3:31 ` Ben Greear
2012-04-18 4:05 ` Johannes Berg
2012-04-18 16:19 ` Ben Greear
2012-04-18 22:40 ` Johannes Berg
2012-04-18 22:54 ` Ben Greear
2012-04-19 4:37 ` Johannes Berg
2012-04-17 17:46 ` [PATCH v2 6/6] mac80211: Add sta_state to ethtool stats greearb
2012-04-18 1:42 ` Johannes Berg
2012-04-18 1:44 ` [PATCH v2 0/6] Add ethtool stats support for Wireless Devices Johannes Berg
2012-04-18 3:56 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8F4734.7050201@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).