From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.candelatech.com ([208.74.158.172]:53884 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754253Ab2DRW7D (ORCPT ); Wed, 18 Apr 2012 18:59:03 -0400 Message-ID: <4F8F4734.7050201@candelatech.com> (sfid-20120419_005910_683679_B1A87698) Date: Wed, 18 Apr 2012 15:59:00 -0700 From: Ben Greear MIME-Version: 1.0 To: Johannes Berg CC: linux-wireless@vger.kernel.org Subject: Re: [PATCH v2 2/6] mac80211: Support getting sta_info stats via ethtool. References: <1334684807-14026-1-git-send-email-greearb@candelatech.com> <1334684807-14026-3-git-send-email-greearb@candelatech.com> (sfid-20120417_194716_243783_5644375D) <1334713070.3725.14.camel@jlt3.sipsolutions.net> <4F8E3905.70900@candelatech.com> <1334721645.3672.2.camel@jlt3.sipsolutions.net> <4F8EEB6C.1030605@candelatech.com> <4F8F42B0.8010306@sipsolutions.net> In-Reply-To: <4F8F42B0.8010306@sipsolutions.net> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 04/18/2012 03:39 PM, Johannes Berg wrote: > On 4/18/2012 9:27 AM, Ben Greear wrote: >>> Oh, right, it's adding, I missed that. But is that really useful? >> >> It provides a summary for AP, and precise stats for managed station >> mode (excepting TDLS where it may return sums, it seems). > > I just have a feeling that people will rely on it working for managed mode, and will forget about TDLS since it's uncommon now ... so I really don't think this > will work well with people's (even yours!) expectations. Ok, how about for managed mode, I will find the first non-TDLS station matching the netdev, assign the values, and then quit looking for more stations. For all other modes, logic stays the same as it is now (add all stations' stats together as long as the station belongs to the netdev)? Thanks, Ben > > johannes -- Ben Greear Candela Technologies Inc http://www.candelatech.com