Re: [PATCH v2 2/6] mac80211: Support getting sta_info stats via ethtool.

[Johannes Berg <johannes@sipsolutions.net>]

On 4/18/2012 3:59 PM, Ben Greear wrote:
> On 04/18/2012 03:39 PM, Johannes Berg wrote:
>> On 4/18/2012 9:27 AM, Ben Greear wrote:
>>>> Oh, right, it's adding, I missed that. But is that really useful?
>>>
>>> It provides a summary for AP, and precise stats for managed station
>>> mode (excepting TDLS where it may return sums, it seems).
>>
>> I just have a feeling that people will rely on it working for managed
>> mode, and will forget about TDLS since it's uncommon now ... so I
>> really don't think this
>> will work well with people's (even yours!) expectations.
>
> Ok, how about for managed mode, I will find the first non-TDLS station
> matching the netdev, assign the values, and then quit looking for more
> stations.
>
> For all other modes, logic stays the same as it is now
> (add all stations' stats together as long as the station belongs
> to the netdev)?

Seems OK, but I'd implement it using the BSSID & getting the station 
rather than iterating? Though if you want the iteration for other 
interface types then I guess it'll be easier to just do it that way.

I just think it's bad to have relatively rare things like TDLS influence 
APIs that people might come to rely on.

johannes