From: Felix Fietkau <nbd@openwrt.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH v3 2/2] mac80211: fix num_mcast_sta counting issues
Date: Sun, 22 Apr 2012 21:54:17 +0200 [thread overview]
Message-ID: <4F9461E9.2050504@openwrt.org> (raw)
In-Reply-To: <1335045079.6516.4.camel@jlt3.sipsolutions.net>
On 2012-04-21 11:51 PM, Johannes Berg wrote:
> On Sat, 2012-04-21 at 23:42 +0200, Felix Fietkau wrote:
>
>> rcu_assign_pointer(vlansdata->u.vlan.sta, sta);
>> + new_4addr = true;
>> }
>>
>> + if (sta->sdata->vif.type == NL80211_IFTYPE_AP_VLAN &&
>> + sta->sdata->u.vlan.sta)
>> + prev_4addr = true;
>
> Doesn't that have to be before the assignment or something, otherwise
> it's always just true unless it was moved back to the AP iface, but
> still true if it was just assigned to an AP_VLAN iface?
This is just before the 'sta->sdata = vlansdata;' line, so it should be
OK. Or am I missing something here?
- Felix
next prev parent reply other threads:[~2012-04-22 19:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 21:42 [PATCH v3 1/2] mac80211: rename AP variable num_sta_authorized to num_mcast_sta Felix Fietkau
2012-04-21 21:42 ` [PATCH v3 2/2] mac80211: fix num_mcast_sta counting issues Felix Fietkau
2012-04-21 21:51 ` Johannes Berg
2012-04-21 21:54 ` Johannes Berg
2012-04-22 19:54 ` Felix Fietkau [this message]
2012-04-23 6:47 ` Johannes Berg
2012-04-21 21:58 ` [PATCH v3 1/2] mac80211: rename AP variable num_sta_authorized to num_mcast_sta Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9461E9.2050504@openwrt.org \
--to=nbd@openwrt.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).