From: Vitaly Wool <vitalywool@gmail.com>
To: <linux-wireless@vger.kernel.org>
Subject: [PATCH/RFC] mac80211: wake queues if ieee80211_suspend failed
Date: Mon, 23 Apr 2012 16:57:22 +0200 [thread overview]
Message-ID: <4F956DD2.2020309@gmail.com> (raw)
Hi,
Sometimes I'm seeing that after a rejected suspend which was
rejected by the driver's suspend routine, the device can not
associate to any AP any more. Investigation shows that it's
due to the fact that the queues are left stopped with the
reason IEEE80211_QUEUE_STOP_REASON_SUSPEND.
With that known, it looks like we need to wake queues on an
unsuccessful suspend attempt explicitly.
---
net/mac80211/pm.c | 2 ++
1 file changed, 2 insertions(+), 0 deletions(-)
diff --git a/net/mac80211/pm.c b/net/mac80211/pm.c
index 844cefb..fd57913 100644
--- a/net/mac80211/pm.c
+++ b/net/mac80211/pm.c
@@ -96,6 +96,8 @@ int __ieee80211_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wowlan)
int err = drv_suspend(local, wowlan);
if (err) {
local->quiescing = false;
+ ieee80211_wake_queues_by_reason(hw,
+ IEEE80211_QUEUE_STOP_REASON_SUSPEND);
return err;
}
list_for_each_entry(sdata,&local->interfaces, list) {
--
1.7.5.4
--
Vitaly Wool<vitalywool@gmail.com>
next reply other threads:[~2012-04-23 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 14:57 Vitaly Wool [this message]
2012-04-23 15:30 ` [PATCH/RFC] mac80211: wake queues if ieee80211_suspend failed Eliad Peller
2012-05-02 19:29 ` Vitaly Wool
2012-05-03 19:34 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F956DD2.2020309@gmail.com \
--to=vitalywool@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).