From: Kalle Valo <kvalo@qca.qualcomm.com>
To: "Luis R. Rodriguez" <mcgrof@frijolero.org>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] wireless: properly use pr_fmt()
Date: Wed, 25 Apr 2012 09:49:44 +0300 [thread overview]
Message-ID: <4F979E88.2020009@qca.qualcomm.com> (raw)
In-Reply-To: <1335234998-31547-1-git-send-email-mcgrof@frijolero.org>
On 04/24/2012 05:36 AM, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@frijolero.org>
>
> pr_fmt() is either defined or we redefine it. Typically
> drivers define it prior to including printk.h but this
> is done under the assumption that no other subsystem
> it uses has already defined pr_fmt(). In such cases
> pr_fmt() should be undefined and redefined.
>
> Doing this properly shaves down compilation time quite
> considerably.
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@frijolero.org>
> ---
>
> I left out only ath6kl as ath6kl folks get groggy it seems
> if you do not go through their tree. Bleh.
Yeah, I prefer ath6kl patches going to ath6kl.git first just to avoid
conflicts when merging. But simple patches like this are not an issue,
conflicts are unlikely or are easy to fix.
Kalle
next prev parent reply other threads:[~2012-04-25 6:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 2:36 [PATCH 1/2] wireless: properly use pr_fmt() Luis R. Rodriguez
2012-04-24 2:36 ` [PATCH 2/2] ath6kl: " Luis R. Rodriguez
2012-04-26 11:35 ` Kalle Valo
2012-04-24 5:50 ` [PATCH 1/2] wireless: " Johannes Berg
2012-04-24 6:41 ` Luis R. Rodriguez
2012-04-25 6:49 ` Kalle Valo [this message]
2012-04-26 12:44 ` Arend van Spriel
2012-04-26 12:54 ` Arend van Spriel
2012-04-26 13:03 ` Hauke Mehrtens
2012-04-26 13:15 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F979E88.2020009@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@frijolero.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).