From: Florian Fainelli <florian@openwrt.org>
To: Nathan Hintz <nlhintz@hotmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org, hauke@hauke-m.de
Subject: Re: [PATCH 3/6] bcma: Account for variable PCI memory base/size
Date: Wed, 25 Apr 2012 10:47:22 +0200 [thread overview]
Message-ID: <4F97BA1A.6050600@openwrt.org> (raw)
In-Reply-To: <BLU0-SMTP82FF4247B6804576EBAE9AAC270@phx.gbl>
Hi Nathan,
Le 04/25/12 08:15, Nathan Hintz a écrit :
> ---
> drivers/bcma/driver_pci_host.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bcma/driver_pci_host.c b/drivers/bcma/driver_pci_host.c
> index d2097a1..3578e1a 100644
> --- a/drivers/bcma/driver_pci_host.c
> +++ b/drivers/bcma/driver_pci_host.c
> @@ -491,8 +491,9 @@ void __devinit bcma_core_pci_hostmode_init(struct bcma_drv_pci *pc)
> /* Ok, ready to run, register it to the system.
> * The following needs change, if we want to port hostmode
> * to non-MIPS platform. */
> - io_map_base = (unsigned long)ioremap_nocache(BCMA_SOC_PCI_MEM,
> - 0x04000000);
> + io_map_base = (unsigned long)ioremap_nocache(pc_host->mem_resource.start,
> + pc_host->mem_resource.end -
> + pc_host->mem_resource.start + 1);
Please use resource_size(pc_host->mem_resource) instead of open-coding
the size computation here.
> pc_host->pci_controller.io_map_base = io_map_base;
> set_io_port_base(pc_host->pci_controller.io_map_base);
> /* Give some time to the PCI controller to configure itself with the new
next prev parent reply other threads:[~2012-04-25 8:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1335334519-18820-1-git-send-email-nlhintz@hotmail.com>
2012-04-25 6:15 ` [PATCH 1/6] bcma: Find names of non BCM cores Nathan Hintz
2012-04-25 8:48 ` Florian Fainelli
2012-04-25 18:18 ` Hauke Mehrtens
2012-04-25 6:15 ` [PATCH 2/6] bcma: Move initialization of SPROM to prevent overwrite Nathan Hintz
2012-04-25 6:15 ` [PATCH 3/6] bcma: Account for variable PCI memory base/size Nathan Hintz
2012-04-25 8:47 ` Florian Fainelli [this message]
2012-04-25 6:15 ` [PATCH 4/6] bcma: reads/writes are always 4 bytes, so always map 4 bytes Nathan Hintz
2012-04-25 6:15 ` [PATCH 5/6] bcma: Add __devexit to bcma_host_pci_remove Nathan Hintz
2012-04-25 6:15 ` [PATCH 6/6] bcma: Add flush for BCMA_RESET_CTL write Nathan Hintz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F97BA1A.6050600@openwrt.org \
--to=florian@openwrt.org \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nlhintz@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).