From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, <ath6kl-devel@qualcomm.com>
Subject: Re: [PATCH 2/2] ath6kl: Complete failed tx packet in ath6kl_htc_tx_from_queue()
Date: Thu, 26 Apr 2012 21:21:41 +0300 [thread overview]
Message-ID: <4F999235.3060007@qca.qualcomm.com> (raw)
In-Reply-To: <1335452174-7093-2-git-send-email-vthiagar@qca.qualcomm.com>
On 04/26/2012 05:56 PM, Vasanthakumar Thiagarajan wrote:
> Return status of ath6kl_htc_tx_issue() is ignored in
> ath6kl_htc_tx_from_queue(), but failed tx packet is
> is not cleaned up. To fix memory leak in this case, call
> completion with error. Also, throw an error debug message
> when tx fails in ath6kl_sdio_write_async() due to shortage
> in bus request buffer.
>
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
[...]
> bus_req = ath6kl_sdio_alloc_busreq(ar_sdio);
>
> - if (!bus_req)
> + if (!bus_req) {
> + ath6kl_err("Ran out of bus request buffer for tx\n");
> return -ENOMEM;
> + }
I'm not sure about this one. There's a risk that this will spam the log.
Should it be a debug message instead? Or should we have instead
ath6kl_err_ratelimit()?
Kalle
next prev parent reply other threads:[~2012-04-26 18:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 14:56 [PATCH 1/2] ath6kl: Update netstats for some of the tx failrues in ath6kl_data_tx() Vasanthakumar Thiagarajan
2012-04-26 14:56 ` [PATCH 2/2] ath6kl: Complete failed tx packet in ath6kl_htc_tx_from_queue() Vasanthakumar Thiagarajan
2012-04-26 18:21 ` Kalle Valo [this message]
2012-04-27 4:09 ` Vasanthakumar Thiagarajan
2012-04-27 6:34 ` Kalle Valo
2012-04-27 6:52 ` Vasanthakumar Thiagarajan
2012-04-30 7:57 ` [PATCH 1/2] ath6kl: Update netstats for some of the tx failrues in ath6kl_data_tx() Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2012-05-22 7:22 [PATCH] ath6kl: Fix missing gpio pin 9 configuration Vasanthakumar Thiagarajan
2012-05-22 7:22 ` [PATCH 2/2] ath6kl: Complete failed tx packet in ath6kl_htc_tx_from_queue() Vasanthakumar Thiagarajan
2012-05-22 7:25 ` Vasanthakumar Thiagarajan
2012-05-22 12:28 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F999235.3060007@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).