Re: [PATCH v2 0/6] BCMA Cumulative patches from OpenWRT

["Arend van Spriel" <arend@broadcom.com>]

On 05/02/2012 08:11 PM, John W. Linville wrote:
> On Thu, Apr 26, 2012 at 02:50:54PM +0300, Kalle Valo wrote:
>> "Arend van Spriel" <arend@broadcom.com> writes:
>>
>>> On 04/26/2012 06:23 AM, Nathan Hintz wrote:
>>>> Nathan Hintz (6):
>>>>    bcma: Find names of non BCM cores
>>>>    bcma: Move initialization of SPROM to prevent overwrite
>>>>    bcma: Account for variable PCI memory base/size
>>>>    bcma: reads/writes are always 4 bytes, so always map 4 bytes
>>>>    bcma: Add __devexit to bcma_host_pci_remove
>>>>    bcma: Add flush for BCMA_RESET_CTL write
>>>>
>>>>   arch/mips/bcm47xx/setup.c      |    4 +++
>>>>   arch/mips/bcm47xx/sprom.c      |    2 -
>>>>   drivers/bcma/core.c            |    1 +
>>>>   drivers/bcma/driver_pci_host.c |   10 +++---
>>>>   drivers/bcma/host_pci.c        |    4 +-
>>>>   drivers/bcma/scan.c            |   54 +++++++++++++++++++++++++++++----------
>>>>   6 files changed, 52 insertions(+), 23 deletions(-)
>>>>
>>>
>>> None of these patches have any description. Some motivation for the
>>> changes would be appreciated like 'reported problem', 'new target
>>> support', etc.
>>
>> I would say that it's required. Anyone can see the diff and see what was
>> changed, but nobody will figure out why the change was made unless it's
>> described in the commit log. So it's important to answer the question
>> "Why?".
> 
> Will we be seeing this patchset reposted with better changelogs?
> 
> John

Although not strongly stated by me I was certainly expecting a re-post.

Gr. AvS