From: "Arend van Spriel" <arend@broadcom.com>
To: "Nathan Hintz" <nlhintz@hotmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"Kalle Valo" <kvalo@adurom.com>,
linux-wireless@vger.kernel.org, hauke@hauke-m.de
Subject: Re: [PATCH v2 0/6] BCMA Cumulative patches from OpenWRT
Date: Thu, 3 May 2012 08:11:46 +0200 [thread overview]
Message-ID: <4FA221A2.10701@broadcom.com> (raw)
In-Reply-To: <BLU0-SMTP243D8B9F11F7BC3D5419A97AC2F0@phx.gbl>
On 05/03/2012 07:04 AM, Nathan Hintz wrote:
> I will repost; it will probably be a few days though. I haven't used
> GIT before other than cloning some repo's, so I have a learning curve to
> overcome.
>
> Any hints are welcome.
>
> Thanks,
> Nathan
Adding a description to a change is not a git specific thing, but a scm
best-practice. To easily add a description to each of your patches is by
doing an interactive rebase (details in [1]).
$ git rebase -i HEAD~6
* this will pop-up your favorite editor
* each line starts with word 'pick'
* replace it with letter 'r'
* close the editor
git will open the editor for each change and let you enter a
description. After that you can recreate your patches.
$ git format-patch --subject-prefix="PATCH v3" --cover-letter -s -M -6
I always give the -M to catch renames and -s to add signed-off-by.
Hope this helps.
Gr. AvS
[1] http://book.git-scm.com/4_interactive_rebasing.html
prev parent reply other threads:[~2012-05-03 6:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 4:23 [PATCH v2 0/6] BCMA Cumulative patches from OpenWRT Nathan Hintz
2012-04-26 8:56 ` Arend van Spriel
2012-04-26 11:50 ` Kalle Valo
2012-05-02 18:11 ` John W. Linville
2012-05-02 18:53 ` Arend van Spriel
2012-05-03 5:04 ` Nathan Hintz
2012-05-03 6:11 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA221A2.10701@broadcom.com \
--to=arend@broadcom.com \
--cc=hauke@hauke-m.de \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nlhintz@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).