From: Hauke Mehrtens <hauke@hauke-m.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: mcgrof@gmail.com, lf_driver_backport@lists.linux-foundation.org,
linux-wireless@vger.kernel.org
Subject: Re: [RFC c-w 2/4] compat-wireless: also copy include/generated/ from compat
Date: Thu, 03 May 2012 21:05:32 +0200 [thread overview]
Message-ID: <4FA2D6FC.4030109@hauke-m.de> (raw)
In-Reply-To: <1336071426.5167.6.camel@jlt3.sipsolutions.net>
On 05/03/2012 08:57 PM, Johannes Berg wrote:
> On Thu, 2012-04-26 at 20:07 +0200, Hauke Mehrtens wrote:
>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>> ---
>> scripts/admin-update.sh | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/scripts/admin-update.sh b/scripts/admin-update.sh
>> index fd1fa87..7147ff1 100755
>> --- a/scripts/admin-update.sh
>> +++ b/scripts/admin-update.sh
>> @@ -283,6 +283,7 @@ mkdir -p include/linux/ include/net/ include/linux/usb \
>> include/trace \
>> include/pcmcia \
>> include/crypto \
>> + include/generated \
>
> Are you sure we want this? It seems to me that most generated things
> like asm-offsets etc. need to be taken from the *target* kernel.
The directory include/generated/ in compat, just contains
include/generated/autoconf.h, which will include linux/compat_autoconf.h
and the original file from the kernel. This way the compat_autoconf.h
will always be included when autoconf.h gets included.
See "[RFC c 2/9] compat: include compat_autoconf.h"
I do not think there will be any other header in include/generated/ we
want to extend or overwrite in compat.
Hauke
next prev parent reply other threads:[~2012-05-03 19:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 18:07 [RFC 0/9] compat-wireless: restructure header files in compat Hauke Mehrtens
2012-04-26 18:07 ` [RFC c 1/9] compat: move compat_system_workqueue_{create,destroy} and compat_pm_qos_power_{init,deinit} Hauke Mehrtens
2012-04-26 18:07 ` [RFC c-w 1/4] compat-wireless: fix header of compat-autoconf.h Hauke Mehrtens
2012-04-26 18:07 ` [RFC c 2/9] compat: include compat_autoconf.h Hauke Mehrtens
2012-04-26 18:07 ` [RFC c-w 2/4] compat-wireless: also copy include/generated/ from compat Hauke Mehrtens
2012-05-03 18:57 ` Johannes Berg
2012-05-03 19:05 ` Hauke Mehrtens [this message]
2012-05-03 19:20 ` Johannes Berg
2012-04-26 18:07 ` [RFC c 3/9] compat: move br_port_exists Hauke Mehrtens
2012-04-26 18:07 ` [RFC c-w 3/4] compat-wireless: do not include linux/compat-2.6.h any more Hauke Mehrtens
2012-04-26 18:07 ` [RFC c 4/9] compat: move netdev_attach_ops Hauke Mehrtens
2012-04-26 18:07 ` [RFC c-w 4/4] compat-wireless: copy *.h files from compat/compat Hauke Mehrtens
2012-04-26 18:07 ` [RFC c 5/9] compat: move compat_pci_{suspend,resume} Hauke Mehrtens
2012-04-26 18:07 ` [RFC c 6/9] compat: move simple_open() Hauke Mehrtens
2012-04-26 18:07 ` [RFC c 7/9] compat: move code from compat-3.4.h Hauke Mehrtens
2012-04-26 18:07 ` [RFC c 8/9] compat: move code from compat-3.3.h Hauke Mehrtens
2012-04-26 18:07 ` [RFC c 9/9] compat: do not include compat-2.6.h Hauke Mehrtens
2012-05-03 18:58 ` [RFC 0/9] compat-wireless: restructure header files in compat Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA2D6FC.4030109@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=johannes@sipsolutions.net \
--cc=lf_driver_backport@lists.linux-foundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).