[PATCH] brcm80211: Remove an unused variable.

[PATCH] brcm80211: Remove an unused variable.

[Il Han]

The variable val is not used afterward.
Remove the declaration and the assignment line of it.

Signed-off-by: Il Han <corone.il.han@gmail.com>
---
 drivers/net/wireless/brcm80211/brcmsmac/aiutils.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/brcm80211/brcmsmac/aiutils.c b/drivers/net/wireless/brcm80211/brcmsmac/aiutils.c
index c93ea35..f79b526 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/aiutils.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/aiutils.c
@@ -1141,7 +1141,6 @@ u32 ai_gpiocontrol(struct si_pub *sih, u32 mask, u32 val, u8 priority)
 void ai_chipcontrl_epa4331(struct si_pub *sih, bool on)
 {
 	struct bcma_device *cc;
-	u32 val;
 
 	cc = ai_findcore(sih, CC_CORE_ID, 0);
 
@@ -1156,7 +1155,6 @@ void ai_chipcontrl_epa4331(struct si_pub *sih, bool on)
 			bcma_set32(cc, CHIPCREGOFFS(chipcontrol),
 				   CCTRL4331_EXTPA_EN);
 	} else {
-		val &= ~(CCTRL4331_EXTPA_EN | CCTRL4331_EXTPA_ON_GPIO2_5);
 		bcma_mask32(cc, CHIPCREGOFFS(chipcontrol),
 			    ~(CCTRL4331_EXTPA_EN | CCTRL4331_EXTPA_ON_GPIO2_5));
 	}
-- 
1.7.4.1

Re: [PATCH] brcm80211: Remove an unused variable.

[Franky Lin]

On 05/07/2012 11:35 PM, Il Han wrote:
> The variable val is not used afterward.
> Remove the declaration and the assignment line of it.
>
> Signed-off-by: Il Han<corone.il.han@gmail.com>
> ---

Thanks Il. Add John as recipient as well.

Acked-by: Franky Lin <frankyl@broadcom.com>

Regards,
Franky

Re: [PATCH] brcm80211: Remove an unused variable.

[Arend van Spriel]

On 05/08/2012 08:05 PM, Franky Lin wrote:
> On 05/07/2012 11:35 PM, Il Han wrote:
>> The variable val is not used afterward.
>> Remove the declaration and the assignment line of it.
>>
>> Signed-off-by: Il Han<corone.il.han@gmail.com>
>> ---
> 
> Thanks Il. Add John as recipient as well.
> 
> Acked-by: Franky Lin <frankyl@broadcom.com>
> 
> Regards,
> Franky

My rule of thumb:

use get_maintainer.pl script and address you patches to the given
maintainer (9 out of 10 you get a sensible maintainer from it).

So for this patch, send the patch to John Linville and CC linux-wireless
list and others you consider specially interested.

Gr. AvS

Re: [PATCH] brcm80211: Remove an unused variable.

[Hauke Mehrtens]

On 05/08/2012 08:35 AM, Il Han wrote:
> The variable val is not used afterward.
> Remove the declaration and the assignment line of it.
> 
> Signed-off-by: Il Han <corone.il.han@gmail.com>
> ---
>  drivers/net/wireless/brcm80211/brcmsmac/aiutils.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/aiutils.c b/drivers/net/wireless/brcm80211/brcmsmac/aiutils.c
> index c93ea35..f79b526 100644
> --- a/drivers/net/wireless/brcm80211/brcmsmac/aiutils.c
> +++ b/drivers/net/wireless/brcm80211/brcmsmac/aiutils.c
> @@ -1141,7 +1141,6 @@ u32 ai_gpiocontrol(struct si_pub *sih, u32 mask, u32 val, u8 priority)
>  void ai_chipcontrl_epa4331(struct si_pub *sih, bool on)
>  {
>  	struct bcma_device *cc;
> -	u32 val;
>  
>  	cc = ai_findcore(sih, CC_CORE_ID, 0);
>  
> @@ -1156,7 +1155,6 @@ void ai_chipcontrl_epa4331(struct si_pub *sih, bool on)
>  			bcma_set32(cc, CHIPCREGOFFS(chipcontrol),
>  				   CCTRL4331_EXTPA_EN);
>  	} else {
> -		val &= ~(CCTRL4331_EXTPA_EN | CCTRL4331_EXTPA_ON_GPIO2_5);
>  		bcma_mask32(cc, CHIPCREGOFFS(chipcontrol),
>  			    ~(CCTRL4331_EXTPA_EN | CCTRL4331_EXTPA_ON_GPIO2_5));
>  	}

Hi,

I send a patch to remove the hole function [0] as it is not referenced
in brcmsmac and a function doing the same thing is already in bcma.
I have no problem with this patch and I hope merging this should not be
hard.

Hauke

[0]: http://www.spinics.net/lists/linux-wireless/msg89364.html