From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Arik Nemtsov <arik@wizery.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: allow low-level drivers to set netdev feature bits
Date: Wed, 09 May 2012 07:19:16 -0700 [thread overview]
Message-ID: <4FAA7CE4.1060609@candelatech.com> (raw)
In-Reply-To: <1336543867.4323.1.camel@jlt3.sipsolutions.net>
On 05/08/2012 11:11 PM, Johannes Berg wrote:
> On Tue, 2012-05-08 at 22:53 +0300, Arik Nemtsov wrote:
>> Allow low-level drivers to change the feature bit for a vif's underlying
>> net_device struct.
>
> What are you planning to use this for? I'm not really sure I see the
> need for an exported function? Is it not going to just be set the same
> for all interfaces?
>
> Out of the many netdev feature bits, we can handle maybe a handful in
> mac80211, so I'm worried this API will suggest to people they can look
> at netdev_features.h...
If the regular ethtool api is implemented, we might could support
some of the features like 'rx-all' that instruct the driver to
pass (more) errored frames up the stack...
But, I have no idea what the original poster was trying to accomplish.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2012-05-09 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 19:53 [PATCH 1/2] mac80211: fix network header location when adding encryption headers Arik Nemtsov
2012-05-08 19:53 ` [PATCH 2/2] mac80211: allow low-level drivers to set netdev feature bits Arik Nemtsov
2012-05-08 20:15 ` Ben Greear
2012-05-09 6:11 ` Johannes Berg
2012-05-09 14:19 ` Ben Greear [this message]
2012-05-09 15:02 ` Arik Nemtsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAA7CE4.1060609@candelatech.com \
--to=greearb@candelatech.com \
--cc=arik@wizery.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).