[PATCH -next] wireless: TI wlxxx depends on MAC80211

[PATCH -next] wireless: TI wlxxx depends on MAC80211

[Randy Dunlap]

From: Randy Dunlap <rdunlap@xenotime.net>

wl12xx build fails with many undefined symbol errors when MAC80211
and CFG80211 are not enabled, so make WLCORE and WL12XX depend
on MAC80211 (which already depends on CFG80211).

Here are a few of the many build errors:

drivers/built-in.o: In function `wl1271_register_hw':
main.c:(.text+0x4197cd): undefined reference to `ieee80211_register_hw'
drivers/built-in.o: In function `wl1271_rx_streaming_timer':
main.c:(.text+0x419818): undefined reference to `ieee80211_queue_work'
drivers/built-in.o: In function `wl1271_flush_deferred_work':
main.c:(.text+0x419910): undefined reference to `ieee80211_rx'
main.c:(.text+0x419938): undefined reference to `ieee80211_tx_status'
drivers/built-in.o: In function `wl12xx_op_channel_switch':
main.c:(.text+0x419afc): undefined reference to `ieee80211_chswitch_done'
drivers/built-in.o: In function `wl1271_ssid_set':
drivers/built-in.o: In function `wl1271_event_process':
event.c:(.text+0x41fec4): undefined reference to `ieee80211_sched_scan_stopped'
event.c:(.text+0x41ff88): undefined reference to `ieee80211_cqm_rssi_notify'
event.c:(.text+0x42000d): undefined reference to `ieee80211_stop_rx_ba_session'
event.c:(.text+0x420048): undefined reference to `ieee80211_stop_rx_ba_session'
event.c:(.text+0x4200b8): undefined reference to `ieee80211_chswitch_done'
event.c:(.text+0x4201ae): undefined reference to `ieee80211_find_sta'
event.c:(.text+0x4201ba): undefined reference to `ieee80211_report_low_ack'
event.c:(.text+0x42021b): undefined reference to `ieee80211_connection_loss'
drivers/built-in.o: In function `wl1271_tx_complete_packet':
tx.c:(.text+0x4206a6): undefined reference to `ieee80211_get_hdrlen_from_skb'
drivers/built-in.o: In function `wl1271_tx_fill_hdr':
tx.c:(.text+0x4208ca): undefined reference to `ieee80211_hdrlen'
drivers/built-in.o: In function `wl1271_handle_tx_low_watermark':
(.text+0x420e25): undefined reference to `ieee80211_wake_queue'
drivers/built-in.o: In function `wl12xx_rearm_rx_streaming':
(.text+0x420ed9): undefined reference to `ieee80211_queue_work'
drivers/built-in.o: In function `wl1271_tx_work_locked':
(.text+0x421008): undefined reference to `ieee80211_free_txskb'
drivers/built-in.o: In function `wl1271_rx_status.clone.2':
rx.c:(.text+0x421593): undefined reference to `ieee80211_channel_to_frequency'
drivers/built-in.o: In function `wl1271_ps_filter_frames':
ps.c:(.text+0x421a41): undefined reference to `ieee80211_tx_status'

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc:	Luciano Coelho <coelho@ti.com>
Cc:	linux-wireless@vger.kernel.org
Cc:	"John W. Linville" <linville@tuxdriver.com>
---
 drivers/net/wireless/ti/wl12xx/Kconfig |    1 +
 drivers/net/wireless/ti/wlcore/Kconfig |    2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

--- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig
+++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig
@@ -1,5 +1,6 @@
 config WL12XX
        tristate "TI wl12xx support"
+	depends on MAC80211
        select WLCORE
        ---help---
 	  This module adds support for wireless adapters based on TI wl1271,
--- linux-next-20120416.orig/drivers/net/wireless/ti/wlcore/Kconfig
+++ linux-next-20120416/drivers/net/wireless/ti/wlcore/Kconfig
@@ -1,6 +1,6 @@
 config WLCORE
 	tristate "TI wlcore support"
-	depends on WL_TI && GENERIC_HARDIRQS
+	depends on WL_TI && GENERIC_HARDIRQS && MAC80211
 	depends on INET
 	select FW_LOADER
 	---help---

Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211

[Luciano Coelho]

Hi Randy,

On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote: 
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> wl12xx build fails with many undefined symbol errors when MAC80211
> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
> on MAC80211 (which already depends on CFG80211).
> 
> Here are a few of the many build errors:
> 

[...]

> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc:	Luciano Coelho <coelho@ti.com>
> Cc:	linux-wireless@vger.kernel.org
> Cc:	"John W. Linville" <linville@tuxdriver.com>
> ---

Thanks for the patch!


> --- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig
> +++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig
> @@ -1,5 +1,6 @@
>  config WL12XX
>         tristate "TI wl12xx support"
> +	depends on MAC80211
>         select WLCORE

Do we really need this one? wl12xx selects WLCORE which in turn depends
on MAC80211 (with your change below).  Maybe we don't need this?


> ---help---
>  	  This module adds support for wireless adapters based on TI wl1271,
> --- linux-next-20120416.orig/drivers/net/wireless/ti/wlcore/Kconfig
> +++ linux-next-20120416/drivers/net/wireless/ti/wlcore/Kconfig
> @@ -1,6 +1,6 @@
>  config WLCORE
>  	tristate "TI wlcore support"
> -	depends on WL_TI && GENERIC_HARDIRQS
> +	depends on WL_TI && GENERIC_HARDIRQS && MAC80211
>  	depends on INET
>  	select FW_LOADER
>  	---help---

-- 
Cheers,
Luca.

Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211

[Luciano Coelho]

On Tue, 2012-04-17 at 11:29 -0700, Randy Dunlap wrote: 
> On 04/16/2012 10:30 PM, Luciano Coelho wrote:
> 
> > Hi Randy,
> > 
> > On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote: 
> >> From: Randy Dunlap <rdunlap@xenotime.net>
> >>
> >> wl12xx build fails with many undefined symbol errors when MAC80211
> >> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
> >> on MAC80211 (which already depends on CFG80211).
> >>
> >> Here are a few of the many build errors:
> >>
> > 
> > [...]
> > 
> >> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> >> Cc:	Luciano Coelho <coelho@ti.com>
> >> Cc:	linux-wireless@vger.kernel.org
> >> Cc:	"John W. Linville" <linville@tuxdriver.com>
> >> ---
> > 
> > Thanks for the patch!
> > 
> > 
> >> --- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig
> >> +++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig
> >> @@ -1,5 +1,6 @@
> >>  config WL12XX
> >>         tristate "TI wl12xx support"
> >> +	depends on MAC80211
> >>         select WLCORE
> > 
> > Do we really need this one? wl12xx selects WLCORE which in turn depends
> > on MAC80211 (with your change below).  Maybe we don't need this?
> 
> Hi,
> 
> [testing...]
> 
> The build fails if either one of these "depends" is omitted.

Yeah, thanks for testing.  I guess it's because, as Johannes said,
select doesn't check the dependencies of the selected module.

Johannes, thanks for the explanation.


-- 
Cheers,
Luca.

Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211

[Randy Dunlap]

On 04/16/2012 10:30 PM, Luciano Coelho wrote:

> Hi Randy,
> 
> On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote: 
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> wl12xx build fails with many undefined symbol errors when MAC80211
>> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
>> on MAC80211 (which already depends on CFG80211).
>>
>> Here are a few of the many build errors:
>>
> 
> [...]
> 
>> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>> Cc:	Luciano Coelho <coelho@ti.com>
>> Cc:	linux-wireless@vger.kernel.org
>> Cc:	"John W. Linville" <linville@tuxdriver.com>
>> ---
> 
> Thanks for the patch!
> 
> 
>> --- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig
>> +++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig
>> @@ -1,5 +1,6 @@
>>  config WL12XX
>>         tristate "TI wl12xx support"
>> +	depends on MAC80211
>>         select WLCORE
> 
> Do we really need this one? wl12xx selects WLCORE which in turn depends
> on MAC80211 (with your change below).  Maybe we don't need this?

Hi,

[testing...]

The build fails if either one of these "depends" is omitted.


>> ---help---
>>  	  This module adds support for wireless adapters based on TI wl1271,
>> --- linux-next-20120416.orig/drivers/net/wireless/ti/wlcore/Kconfig
>> +++ linux-next-20120416/drivers/net/wireless/ti/wlcore/Kconfig
>> @@ -1,6 +1,6 @@
>>  config WLCORE
>>  	tristate "TI wlcore support"
>> -	depends on WL_TI && GENERIC_HARDIRQS
>> +	depends on WL_TI && GENERIC_HARDIRQS && MAC80211
>>  	depends on INET
>>  	select FW_LOADER
>>  	---help---
> 



-- 
~Randy

Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211

[Luciano Coelho]

On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> wl12xx build fails with many undefined symbol errors when MAC80211
> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
> on MAC80211 (which already depends on CFG80211).
> 
> Here are a few of the many build errors:
> 
> drivers/built-in.o: In function `wl1271_register_hw':
> main.c:(.text+0x4197cd): undefined reference to `ieee80211_register_hw'
> drivers/built-in.o: In function `wl1271_rx_streaming_timer':
> main.c:(.text+0x419818): undefined reference to `ieee80211_queue_work'
> drivers/built-in.o: In function `wl1271_flush_deferred_work':
> main.c:(.text+0x419910): undefined reference to `ieee80211_rx'
> main.c:(.text+0x419938): undefined reference to `ieee80211_tx_status'
> drivers/built-in.o: In function `wl12xx_op_channel_switch':
> main.c:(.text+0x419afc): undefined reference to `ieee80211_chswitch_done'
> drivers/built-in.o: In function `wl1271_ssid_set':
> drivers/built-in.o: In function `wl1271_event_process':
> event.c:(.text+0x41fec4): undefined reference to `ieee80211_sched_scan_stopped'
> event.c:(.text+0x41ff88): undefined reference to `ieee80211_cqm_rssi_notify'
> event.c:(.text+0x42000d): undefined reference to `ieee80211_stop_rx_ba_session'
> event.c:(.text+0x420048): undefined reference to `ieee80211_stop_rx_ba_session'
> event.c:(.text+0x4200b8): undefined reference to `ieee80211_chswitch_done'
> event.c:(.text+0x4201ae): undefined reference to `ieee80211_find_sta'
> event.c:(.text+0x4201ba): undefined reference to `ieee80211_report_low_ack'
> event.c:(.text+0x42021b): undefined reference to `ieee80211_connection_loss'
> drivers/built-in.o: In function `wl1271_tx_complete_packet':
> tx.c:(.text+0x4206a6): undefined reference to `ieee80211_get_hdrlen_from_skb'
> drivers/built-in.o: In function `wl1271_tx_fill_hdr':
> tx.c:(.text+0x4208ca): undefined reference to `ieee80211_hdrlen'
> drivers/built-in.o: In function `wl1271_handle_tx_low_watermark':
> (.text+0x420e25): undefined reference to `ieee80211_wake_queue'
> drivers/built-in.o: In function `wl12xx_rearm_rx_streaming':
> (.text+0x420ed9): undefined reference to `ieee80211_queue_work'
> drivers/built-in.o: In function `wl1271_tx_work_locked':
> (.text+0x421008): undefined reference to `ieee80211_free_txskb'
> drivers/built-in.o: In function `wl1271_rx_status.clone.2':
> rx.c:(.text+0x421593): undefined reference to `ieee80211_channel_to_frequency'
> drivers/built-in.o: In function `wl1271_ps_filter_frames':
> ps.c:(.text+0x421a41): undefined reference to `ieee80211_tx_status'
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc:	Luciano Coelho <coelho@ti.com>
> Cc:	linux-wireless@vger.kernel.org
> Cc:	"John W. Linville" <linville@tuxdriver.com>
> ---

Applied! Thanks Randy, and sorry for the delay in pushing this through
my tree.

Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211

[Randy Dunlap]

On 05/03/2012 05:55 AM, Luciano Coelho wrote:

> On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> wl12xx build fails with many undefined symbol errors when MAC80211
>> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
>> on MAC80211 (which already depends on CFG80211).
>>
>> Here are a few of the many build errors:
>>
>> drivers/built-in.o: In function `wl1271_register_hw':
>> main.c:(.text+0x4197cd): undefined reference to `ieee80211_register_hw'
>> drivers/built-in.o: In function `wl1271_rx_streaming_timer':
>> main.c:(.text+0x419818): undefined reference to `ieee80211_queue_work'
>> drivers/built-in.o: In function `wl1271_flush_deferred_work':
>> main.c:(.text+0x419910): undefined reference to `ieee80211_rx'
>> main.c:(.text+0x419938): undefined reference to `ieee80211_tx_status'
>> drivers/built-in.o: In function `wl12xx_op_channel_switch':
>> main.c:(.text+0x419afc): undefined reference to `ieee80211_chswitch_done'
>> drivers/built-in.o: In function `wl1271_ssid_set':
>> drivers/built-in.o: In function `wl1271_event_process':
>> event.c:(.text+0x41fec4): undefined reference to `ieee80211_sched_scan_stopped'
>> event.c:(.text+0x41ff88): undefined reference to `ieee80211_cqm_rssi_notify'
>> event.c:(.text+0x42000d): undefined reference to `ieee80211_stop_rx_ba_session'
>> event.c:(.text+0x420048): undefined reference to `ieee80211_stop_rx_ba_session'
>> event.c:(.text+0x4200b8): undefined reference to `ieee80211_chswitch_done'
>> event.c:(.text+0x4201ae): undefined reference to `ieee80211_find_sta'
>> event.c:(.text+0x4201ba): undefined reference to `ieee80211_report_low_ack'
>> event.c:(.text+0x42021b): undefined reference to `ieee80211_connection_loss'
>> drivers/built-in.o: In function `wl1271_tx_complete_packet':
>> tx.c:(.text+0x4206a6): undefined reference to `ieee80211_get_hdrlen_from_skb'
>> drivers/built-in.o: In function `wl1271_tx_fill_hdr':
>> tx.c:(.text+0x4208ca): undefined reference to `ieee80211_hdrlen'
>> drivers/built-in.o: In function `wl1271_handle_tx_low_watermark':
>> (.text+0x420e25): undefined reference to `ieee80211_wake_queue'
>> drivers/built-in.o: In function `wl12xx_rearm_rx_streaming':
>> (.text+0x420ed9): undefined reference to `ieee80211_queue_work'
>> drivers/built-in.o: In function `wl1271_tx_work_locked':
>> (.text+0x421008): undefined reference to `ieee80211_free_txskb'
>> drivers/built-in.o: In function `wl1271_rx_status.clone.2':
>> rx.c:(.text+0x421593): undefined reference to `ieee80211_channel_to_frequency'
>> drivers/built-in.o: In function `wl1271_ps_filter_frames':
>> ps.c:(.text+0x421a41): undefined reference to `ieee80211_tx_status'
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>> Cc:	Luciano Coelho <coelho@ti.com>
>> Cc:	linux-wireless@vger.kernel.org
>> Cc:	"John W. Linville" <linville@tuxdriver.com>
>> ---
> 
> Applied! Thanks Randy, and sorry for the delay in pushing this through
> my tree.



Ping.

This patch is still needed in linux-next of 20120510.


-- 
~Randy

Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211

[Luciano Coelho]

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

Hey Randy,

On Thu, 2012-05-10 at 14:25 -0700, Randy Dunlap wrote:
> On 05/03/2012 05:55 AM, Luciano Coelho wrote:
> 
> > On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote:
> >> From: Randy Dunlap <rdunlap@xenotime.net>
> >>
> >> wl12xx build fails with many undefined symbol errors when MAC80211
> >> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
> >> on MAC80211 (which already depends on CFG80211).
> >>
> >> Here are a few of the many build errors:

[...]

> >> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> >> Cc:	Luciano Coelho <coelho@ti.com>
> >> Cc:	linux-wireless@vger.kernel.org
> >> Cc:	"John W. Linville" <linville@tuxdriver.com>
> >> ---
> > 
> > Applied! Thanks Randy, and sorry for the delay in pushing this through
> > my tree.
> 
> 
> 
> Ping.
> 
> This patch is still needed in linux-next of 20120510.

I already applied this patch and sent a pull-request to Linville, but he
hasn't pulled from my tree into wireless-next yet.

Would it make sense for you to pull directly from my tree into
linux-next?

-- 
Cheers,
Luca.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211

[Randy Dunlap]

On 05/10/2012 02:36 PM, Luciano Coelho wrote:

> Hey Randy,
> 
> On Thu, 2012-05-10 at 14:25 -0700, Randy Dunlap wrote:
>> On 05/03/2012 05:55 AM, Luciano Coelho wrote:
>>
>>> On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote:
>>>> From: Randy Dunlap <rdunlap@xenotime.net>
>>>>
>>>> wl12xx build fails with many undefined symbol errors when MAC80211
>>>> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
>>>> on MAC80211 (which already depends on CFG80211).
>>>>
>>>> Here are a few of the many build errors:
> 
> [...]
> 
>>>> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>>>> Cc:	Luciano Coelho <coelho@ti.com>
>>>> Cc:	linux-wireless@vger.kernel.org
>>>> Cc:	"John W. Linville" <linville@tuxdriver.com>
>>>> ---
>>>
>>> Applied! Thanks Randy, and sorry for the delay in pushing this through
>>> my tree.
>>
>>
>>
>> Ping.
>>
>> This patch is still needed in linux-next of 20120510.
> 
> I already applied this patch and sent a pull-request to Linville, but he
> hasn't pulled from my tree into wireless-next yet.
> 
> Would it make sense for you to pull directly from my tree into
> linux-next?


No, I'm just testing/reporting on linux-next.

Thanks.

-- 
~Randy

Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211

[Arend van Spriel]

On 04/16/2012 09:51 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> wl12xx build fails with many undefined symbol errors when MAC80211
> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
> on MAC80211 (which already depends on CFG80211).
> 
> ---
>  drivers/net/wireless/ti/wl12xx/Kconfig |    1 +
>  drivers/net/wireless/ti/wlcore/Kconfig |    2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> --- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig
> +++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig
> @@ -1,5 +1,6 @@
>  config WL12XX
>         tristate "TI wl12xx support"
> +	depends on MAC80211
>         select WLCORE

Similar patch is probably needed for new wl18xx driver.

>         ---help---
>  	  This module adds support for wireless adapters based on TI wl1271,
> --- linux-next-20120416.orig/drivers/net/wireless/ti/wlcore/Kconfig
> +++ linux-next-20120416/drivers/net/wireless/ti/wlcore/Kconfig
> @@ -1,6 +1,6 @@
>  config WLCORE
>  	tristate "TI wlcore support"
> -	depends on WL_TI && GENERIC_HARDIRQS
> +	depends on WL_TI && GENERIC_HARDIRQS && MAC80211
>  	depends on INET
>  	select FW_LOADER
>  	---help---

Gr. AvS