* [patch] brcm80211: brcmu_pkt_buf_free_skb() should handle NULL
@ 2012-05-15 9:00 Dan Carpenter
2012-05-15 14:21 ` Arend van Spriel
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2012-05-15 9:00 UTC (permalink / raw)
To: Brett Rudley
Cc: Roland Vossen, Arend van Spriel, Franky (Zhenhui) Lin, Kan Yan,
John W. Linville, Greg Kroah-Hartman, Pieter-Paul Giesberts,
linux-wireless, kernel-janitors
This is potentially called with NULL pointers, for example, look at
brcmf_c_prec_enq(). Since it's a free() function, probably people
expect it to handle NULL pointers.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/brcm80211/brcmutil/utils.c b/drivers/net/wireless/brcm80211/brcmutil/utils.c
index b45ab34..3e6405e 100644
--- a/drivers/net/wireless/brcm80211/brcmutil/utils.c
+++ b/drivers/net/wireless/brcm80211/brcmutil/utils.c
@@ -43,6 +43,8 @@ EXPORT_SYMBOL(brcmu_pkt_buf_get_skb);
/* Free the driver packet. Free the tag if present */
void brcmu_pkt_buf_free_skb(struct sk_buff *skb)
{
+ if (!skb)
+ return;
WARN_ON(skb->next);
if (skb->destructor)
/* cannot kfree_skb() on hard IRQ (net/core/skbuff.c) if
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch] brcm80211: brcmu_pkt_buf_free_skb() should handle NULL
2012-05-15 9:00 [patch] brcm80211: brcmu_pkt_buf_free_skb() should handle NULL Dan Carpenter
@ 2012-05-15 14:21 ` Arend van Spriel
2012-05-15 14:28 ` Arend van Spriel
2012-05-15 14:44 ` Dan Carpenter
0 siblings, 2 replies; 6+ messages in thread
From: Arend van Spriel @ 2012-05-15 14:21 UTC (permalink / raw)
To: Dan Carpenter
Cc: Brett Rudley, Roland Vossen, Franky (Zhenhui) Lin, Kan Yan,
John W. Linville, Greg Kroah-Hartman, Pieter-Paul Giesberts,
linux-wireless, kernel-janitors
On 05/15/2012 11:00 AM, Dan Carpenter wrote:
> This is potentially called with NULL pointers, for example, look at
> brcmf_c_prec_enq(). Since it's a free() function, probably people
> expect it to handle NULL pointers.
Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/wireless/brcm80211/brcmutil/utils.c b/drivers/net/wireless/brcm80211/brcmutil/utils.c
> index b45ab34..3e6405e 100644
Is the diff command filtered properly here. In most patches I usually
see '---' immediatly after the Signed-off-by line.
> --- a/drivers/net/wireless/brcm80211/brcmutil/utils.c
> +++ b/drivers/net/wireless/brcm80211/brcmutil/utils.c
> @@ -43,6 +43,8 @@ EXPORT_SYMBOL(brcmu_pkt_buf_get_skb);
> /* Free the driver packet. Free the tag if present */
> void brcmu_pkt_buf_free_skb(struct sk_buff *skb)
> {
> + if (!skb)
> + return;
> WARN_ON(skb->next);
> if (skb->destructor)
> /* cannot kfree_skb() on hard IRQ (net/core/skbuff.c) if
>
Gr. AvS
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] brcm80211: brcmu_pkt_buf_free_skb() should handle NULL
2012-05-15 14:21 ` Arend van Spriel
@ 2012-05-15 14:28 ` Arend van Spriel
2012-05-15 14:44 ` Dan Carpenter
1 sibling, 0 replies; 6+ messages in thread
From: Arend van Spriel @ 2012-05-15 14:28 UTC (permalink / raw)
To: Dan Carpenter
Cc: Brett Rudley, Roland Vossen, Franky (Zhenhui) Lin, Kan Yan,
John W. Linville, gregkh@linuxfoundation.org,
Pieter-Paul Giesberts, linux-wireless, kernel-janitors
On 05/15/2012 04:21 PM, Arend van Spriel wrote:
> On 05/15/2012 11:00 AM, Dan Carpenter wrote:
>> This is potentially called with NULL pointers, for example, look at
>> brcmf_c_prec_enq(). Since it's a free() function, probably people
>> expect it to handle NULL pointers.
>
> Acked-by: Arend van Spriel <arend@broadcom.com>
>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
Hi Dan,
By the way. You cc'ed Greg <gregkh@suse.de> but he moved to linux
foundation.
Gr. AvS
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] brcm80211: brcmu_pkt_buf_free_skb() should handle NULL
2012-05-15 14:21 ` Arend van Spriel
2012-05-15 14:28 ` Arend van Spriel
@ 2012-05-15 14:44 ` Dan Carpenter
2012-05-15 15:07 ` Julia Lawall
1 sibling, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2012-05-15 14:44 UTC (permalink / raw)
To: Arend van Spriel
Cc: Brett Rudley, Roland Vossen, Franky (Zhenhui) Lin, Kan Yan,
John W. Linville, Pieter-Paul Giesberts, linux-wireless,
kernel-janitors
On Tue, May 15, 2012 at 04:21:24PM +0200, Arend van Spriel wrote:
> On 05/15/2012 11:00 AM, Dan Carpenter wrote:
> > This is potentially called with NULL pointers, for example, look at
> > brcmf_c_prec_enq(). Since it's a free() function, probably people
> > expect it to handle NULL pointers.
>
> Acked-by: Arend van Spriel <arend@broadcom.com>
>
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/net/wireless/brcm80211/brcmutil/utils.c b/drivers/net/wireless/brcm80211/brcmutil/utils.c
> > index b45ab34..3e6405e 100644
>
> Is the diff command filtered properly here. In most patches I usually
> see '---' immediatly after the Signed-off-by line.
>
Yeah. Normally git puts the diffstat there, but my scripts leave
it out. All my patches are tiny anyway. ;)
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] brcm80211: brcmu_pkt_buf_free_skb() should handle NULL
2012-05-15 14:44 ` Dan Carpenter
@ 2012-05-15 15:07 ` Julia Lawall
2012-05-15 16:57 ` Arend van Spriel
0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2012-05-15 15:07 UTC (permalink / raw)
To: Dan Carpenter
Cc: Arend van Spriel, Brett Rudley, Roland Vossen,
Franky (Zhenhui) Lin, Kan Yan, John W. Linville,
Pieter-Paul Giesberts, linux-wireless, kernel-janitors
On Tue, 15 May 2012, Dan Carpenter wrote:
> On Tue, May 15, 2012 at 04:21:24PM +0200, Arend van Spriel wrote:
>> On 05/15/2012 11:00 AM, Dan Carpenter wrote:
>>> This is potentially called with NULL pointers, for example, look at
>>> brcmf_c_prec_enq(). Since it's a free() function, probably people
>>> expect it to handle NULL pointers.
>>
>> Acked-by: Arend van Spriel <arend@broadcom.com>
>>
>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>>
>>> diff --git a/drivers/net/wireless/brcm80211/brcmutil/utils.c b/drivers/net/wireless/brcm80211/brcmutil/utils.c
>>> index b45ab34..3e6405e 100644
>>
>> Is the diff command filtered properly here. In most patches I usually
>> see '---' immediatly after the Signed-off-by line.
>>
>
> Yeah. Normally git puts the diffstat there, but my scripts leave
> it out. All my patches are tiny anyway. ;)
The documentation says:
The canonical patch message body contains the following:
- A "from" line specifying the patch author.
- An empty line.
- The body of the explanation, which will be copied to the
permanent changelog to describe this patch.
- The "Signed-off-by:" lines, described above, which will
also go in the changelog.
- A marker line containing simply "---".
- Any additional comments not suitable for the changelog.
- The actual patch (diff output).
The --- is not attached to the diffstat, as far as I can see.
julia
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] brcm80211: brcmu_pkt_buf_free_skb() should handle NULL
2012-05-15 15:07 ` Julia Lawall
@ 2012-05-15 16:57 ` Arend van Spriel
0 siblings, 0 replies; 6+ messages in thread
From: Arend van Spriel @ 2012-05-15 16:57 UTC (permalink / raw)
To: Julia Lawall
Cc: Dan Carpenter, Brett Rudley, Roland Vossen, Franky (Zhenhui) Lin,
Kan Yan, John W. Linville, Pieter-Paul Giesberts, linux-wireless,
kernel-janitors
On 05/15/2012 05:07 PM, Julia Lawall wrote:
>
> 1 - A marker line containing simply "---".
>
> 2 - Any additional comments not suitable for the changelog.
>
I guess that 1 can be omitted when there is no 2. I was just wondering
whether the diff command would end up in the changelog when applying the
patch.
Gr. AvS
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-05-15 16:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-15 9:00 [patch] brcm80211: brcmu_pkt_buf_free_skb() should handle NULL Dan Carpenter
2012-05-15 14:21 ` Arend van Spriel
2012-05-15 14:28 ` Arend van Spriel
2012-05-15 14:44 ` Dan Carpenter
2012-05-15 15:07 ` Julia Lawall
2012-05-15 16:57 ` Arend van Spriel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).