linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, <ath6kl-devel@qualcomm.com>,
	Naveen Singh <navesing@qca.qualcomm.com>
Subject: Re: [PATCH] ath6kl: Include match ssid list in scheduled scan
Date: Wed, 16 May 2012 13:34:18 +0300	[thread overview]
Message-ID: <4FB382AA.9030902@qca.qualcomm.com> (raw)
In-Reply-To: <1337164140-16098-1-git-send-email-kvalo@qca.qualcomm.com>

On 05/16/2012 01:29 PM, Kalle Valo wrote:

> +			if ((match_set[i].ssid.ssid_len ==
> +			     ssid_list[j].ssid.ssid_len) &&
> +			    (!memcmp(ssid_list[j].ssid.ssid,
> +				     match_set[i].ssid.ssid,
> +				     match_set[i].ssid.ssid_len))) {
> +				ssid_list[j].flag |= MATCH_SSID_FLAG;
> +				ssid_found = true;
> +				break;
> +			}

Do we have a function like ieee80211_is_same_ssid()? I didn't find
anything like that after a quick search.

I noticed that wlcore had a similar code like we have here. A common
function in cfg80211.h/ieee80211.h for comparing ssids would be nice and
less error prone.

Kalle

  reply	other threads:[~2012-05-16 10:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-16 10:29 [PATCH] ath6kl: Include match ssid list in scheduled scan Kalle Valo
2012-05-16 10:34 ` Kalle Valo [this message]
2012-05-16 13:26 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB382AA.9030902@qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath6kl-devel@qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=navesing@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).