From: "Franky Lin" <frankyl@broadcom.com>
To: "Hauke Mehrtens" <hauke@hauke-m.de>, linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] brcmfmac: use vmalloc to allocate mem for the firmware
Date: Fri, 18 May 2012 11:33:54 -0700 [thread overview]
Message-ID: <4FB69612.6030304@broadcom.com> (raw)
In-Reply-To: <1337365373-12418-1-git-send-email-hauke@hauke-m.de>
On 05/18/2012 11:22 AM, Hauke Mehrtens wrote:
> The firmware is more than 300KB big and you should not use kmalloc for
> such big allocations. This allocation with kmalloc failed on my mips
> based device (BCM47186).
>
> Signed-off-by: Hauke Mehrtens<hauke@hauke-m.de>
> ---
You're right. We have noticed the kmalloc usage probelm but didn't have
time to clean up the mess. Thanks for fixing this one.
Acked-by: Franky Lin <frankyl@broadcom.com>
Franky
prev parent reply other threads:[~2012-05-18 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 18:22 [PATCH] brcmfmac: use vmalloc to allocate mem for the firmware Hauke Mehrtens
2012-05-18 18:33 ` Franky Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB69612.6030304@broadcom.com \
--to=frankyl@broadcom.com \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).