Re: [PATCH] rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER respectively

[Andreas Hartmann <andihartmann@01019freenet.de>]

Andreas Hartmann wrote:
> Helmut Schaa wrote:
>> On Fri, May 18, 2012 at 6:21 PM, Tobias Diedrich <ranma@tdiedrich.de> wrote:
>>>> So, maybe we should do it the safe way and just register a safe default
>>>> of 20dBm for all channels?
>>>
>>> AFAIU that would cap you to 20dBm even if you are in a country that
>>> has higher limits (e.g. 27dBm in the US?).
>>
>> Not necessarily because the driver won't allow tx power adjustments at all
>> if EEPROM_EIRP_MAX_TX_POWER is unused.
> 
> This means:
> Tx settings in cfg80211 as given by "iw reg get" e.g. are ignored
> completely as long as EEPROM_EIRP_MAX_TX_POWER is unused.
> Thus it is more or less chance that the device actually uses the allowed
> / correct Tx power at all. Maybe it's too high or too low. Both would be
> bad.

Please Helmut, I would be really grateful if you could confirm or negate
my conclusion.

>> For these devices we cannot rely on the tx power output at all and maybe
>> it makes sense to register a max power of 0 just to tell mac80211/cfg80211
>> that no tx power adjustments are possible on these devices?
> 
> Hmmm, this sounds really strange. How can I see if a device uses
> EEPROM_EIRP_MAX_TX_POWER at all?
> It would be good to have a log entry, telling the user that the Tx power
> of the device can't be adjusted at all and therefore it is possible,
> that the operation of the device might be illegal in the current country
> even if cfg80211 is set correctly.


Thank you Helmut,
kind regards,
Andreas