From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bala Shanmugam <bkamatch@qca.qualcomm.com>
Cc: <ath6kl-devel@qualcomm.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3] ath6kl: Add support for setting tx rateset.
Date: Thu, 24 May 2012 10:26:55 +0300 [thread overview]
Message-ID: <4FBDE2BF.5050901@qca.qualcomm.com> (raw)
In-Reply-To: <4FBDE27A.2050900@qca.qualcomm.com>
On 05/24/2012 10:25 AM, Kalle Valo wrote:
> On 05/22/2012 10:53 AM, Bala Shanmugam wrote:
>> Tx legacy and mcs rateset can configured using iw for
>> 2.4 and 5 bands. Add support for the same in driver.
>>
>> Signed-off-by: Bala Shanmugam <bkamatch@qca.qualcomm.com>
>
> Thanks, this looks very good now. I did two minor changes still:
>
> kvalo: add an enum for the hw flags and rename the flag accordingly,
> rename ath6kl_cfg80211_set_bitrate_mask() to a shorter version to make
> it easier to indent
>
> The enum looks like this:
>
> enum ath6kl_hw_flags {
> ATH6KL_HW_FLAG_64BIT_RATES = BIT(0),
> };
>
> And I did that just to make it more obvious to group the flags in the
> future.
Oops, I forgot to mention that the patch is now applied to ath6kl.git.
Thanks.
Kalle
prev parent reply other threads:[~2012-05-24 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 7:53 [PATCH v3] ath6kl: Add support for setting tx rateset Bala Shanmugam
2012-05-24 7:25 ` Kalle Valo
2012-05-24 7:26 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBDE2BF.5050901@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=bkamatch@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).