linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Seth Forshee" <seth.forshee@canonical.com>
Cc: linux-wireless@vger.kernel.org,
	"Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
Subject: Re: [RFC PATCH 0/8] brcm80211: smac: rework regulatory support
Date: Sat, 26 May 2012 00:31:36 +0200	[thread overview]
Message-ID: <4FC00848.9060901@broadcom.com> (raw)
In-Reply-To: <1334607462-5387-1-git-send-email-seth.forshee@canonical.com>

On 04/16/2012 10:17 PM, Seth Forshee wrote:
> Hi Arnd,

You missed an 'e' ;-)

> Here's the latest update to the brcmsmac regulatory rework that I've
> been working on. I've broken it up into a series of smaller patches,
> cleaned things up, and finished what changes I can with the information
> available to me.

It took a while. There were some discussions and we agreed that your
changes establish a better integration with the regulatory framework.
There are some concerns about the content of the crda database, but that
is another thing outside the scope of your patches.

> I've attempted to maintain the same high-level behavior that the
> brcmsmac internal regulatory support currently enforces.

Appreciated. We can add/change in subsequent patches. I collected review
comments internally including mine. I will provide them in response to
each individual patch.

General comment: you should run 'checkpatch.pl --strict' script over the
patches. I came across several issues that will probably be flagged by it.

Gr. AvS


  parent reply	other threads:[~2012-05-25 22:31 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16 20:17 [RFC PATCH 0/8] brcm80211: smac: rework regulatory support Seth Forshee
2012-04-16 20:17 ` [RFC PATCH 1/8] brcm80211: smac: don't set up tx power limits during initialization Seth Forshee
2012-05-25 22:32   ` Arend van Spriel
2012-04-16 20:17 ` [RFC PATCH 2/8] brcm80211: smac: always set channel specified by mac80211 Seth Forshee
2012-05-25 22:32   ` Arend van Spriel
2012-04-16 20:17 ` [RFC PATCH 3/8] brcm80211: smac: clean up channel.c Seth Forshee
2012-05-25 22:33   ` Arend van Spriel
2012-05-26 17:17     ` Seth Forshee
2012-05-27 11:51       ` Arend van Spriel
2012-05-27 11:53       ` Arend van Spriel
2012-05-29 12:46         ` Seth Forshee
2012-05-29 13:03           ` Arend van Spriel
2012-04-16 20:17 ` [RFC PATCH 4/8] brcm80211: smac: inform mac80211 of the X2 regulatory domain Seth Forshee
2012-05-25 22:33   ` Arend van Spriel
2012-05-26 17:18     ` Seth Forshee
2012-05-27 12:17       ` Arend van Spriel
2012-05-29 13:12         ` Seth Forshee
2012-05-29 16:44           ` Arend van Spriel
2012-05-31 14:46         ` Seth Forshee
2012-05-31 17:49           ` Arend van Spriel
2012-06-07 18:18       ` Luis R. Rodriguez
2012-04-16 20:17 ` [RFC PATCH 5/8] brcm80211: smac: enable/disable radio on regulatory updates Seth Forshee
2012-05-25 22:33   ` Arend van Spriel
2012-05-26 17:18     ` Seth Forshee
2012-05-27 12:18       ` Arend van Spriel
2012-04-16 20:17 ` [RFC PATCH 6/8] brcm80211: smac: use mac80211 channel data for tx power limits Seth Forshee
2012-05-25 22:33   ` Arend van Spriel
2012-04-16 20:17 ` [RFC PATCH 7/8] brcm80211: smac: don't validate channels against internal regulatory data Seth Forshee
2012-05-25 22:33   ` Arend van Spriel
2012-04-16 20:17 ` [RFC PATCH 8/8] brcm80211: smac: use current regulatory domain when checking whether OFDM is allowed Seth Forshee
2012-05-25 22:34   ` Arend van Spriel
2012-04-16 20:42 ` [RFC PATCH 0/8] brcm80211: smac: rework regulatory support Arend van Spriel
2012-04-16 20:53   ` Seth Forshee
2012-04-19 19:31 ` Arend van Spriel
2012-04-19 19:46   ` Seth Forshee
2012-04-30 17:12   ` Seth Forshee
2012-05-01 12:13     ` Arend van Spriel
2012-05-01 16:12       ` Seth Forshee
2012-05-25 22:31 ` Arend van Spriel [this message]
2012-05-25 22:51   ` Luis R. Rodriguez
2012-05-26  6:38     ` Arend van Spriel
2012-05-26  7:19       ` Luis R. Rodriguez
2012-05-26 17:17   ` Seth Forshee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC00848.9060901@broadcom.com \
    --to=arend@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rodrigue@qca.qualcomm.com \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).