From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Joe Perches <joe@perches.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
<linux-wireless@vger.kernel.org>
Subject: Re: [RFC] mac80211: net_ratelimit few aggregation related messages
Date: Mon, 28 May 2012 11:45:43 +0530 [thread overview]
Message-ID: <4FC3180F.1060902@qca.qualcomm.com> (raw)
In-Reply-To: <1337976166.30100.6.camel@joe2Laptop>
Hi Joe,
On Saturday 26 May 2012 01:32 AM, Joe Perches wrote:
> On Fri, 2012-05-25 at 21:07 +0530, Mohammed Shafi Shajakhan wrote:
>> net_ratelimit few aggregation related messages,
> []
>> diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c
> []
>> @@ -464,8 +464,9 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid,
>> return -EINVAL;
>>
>> #ifdef CONFIG_MAC80211_HT_DEBUG
>> - printk(KERN_DEBUG "Open BA session requested for %pM tid %u\n",
>> - pubsta->addr, tid);
>> + if (net_ratelimit())
>> + printk(KERN_DEBUG "Open BA session requested for %pM tid %u\n",
>> + pubsta->addr, tid);
>
> perhaps
> net_dbg_ratelimited(...)
>
> etc...
>
thanks for your inputs!
just today saw this link where you had introduced net_dbg_ratelimited
http://www.digipedia.pl/usenet/thread/18978/31017/
so should i send the v2 patch using net_dbg_ratelimited to net-next
rather than wireless-testing tree ?
--
thanks,
shafi
next prev parent reply other threads:[~2012-05-28 6:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 15:37 [RFC] mac80211: net_ratelimit few aggregation related messages Mohammed Shafi Shajakhan
2012-05-25 20:02 ` Joe Perches
2012-05-28 6:15 ` Mohammed Shafi Shajakhan [this message]
2012-05-28 6:26 ` Joe Perches
2012-05-28 6:31 ` Mohammed Shafi Shajakhan
2012-05-28 6:43 ` Joe Perches
2012-05-28 6:51 ` Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC3180F.1060902@qca.qualcomm.com \
--to=mohammed@qca.qualcomm.com \
--cc=joe@perches.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).