From: Claudio Pisa <claudio.pisa@uniroma2.it>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix flag check for QoS NOACK frames
Date: Tue, 29 May 2012 16:05:05 +0100 [thread overview]
Message-ID: <4FC4E5A1.3010508@uniroma2.it> (raw)
In-Reply-To: <1338275092.4342.14.camel@jlt3.sipsolutions.net>
On 05/29/2012 08:04 AM, Johannes Berg wrote:
> On Mon, 2012-05-28 at 13:06 +0100, Claudio Pisa wrote:
>> Signed-off-by: Claudio Pisa <claudio.pisa@uniroma2.it>
>> ---
>> net/mac80211/tx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
>> index d67d36f..cb17497 100644
>> --- a/net/mac80211/tx.c
>> +++ b/net/mac80211/tx.c
>> @@ -153,7 +153,7 @@ static __le16 ieee80211_duration(struct ieee80211_tx_data *tx,
>>
>> /* Don't calculate ACKs for QoS Frames with NoAck Policy set */
>> if (ieee80211_is_data_qos(hdr->frame_control) &&
>> - *(ieee80211_get_qos_ctl(hdr)) | IEEE80211_QOS_CTL_ACK_POLICY_NOACK)
>> + *(ieee80211_get_qos_ctl(hdr)) & IEEE80211_QOS_CTL_ACK_POLICY_NOACK)
>
> Looks right to me, I guess nobody cares about duration calculations
> after all. How did you find this?!
Working on a project involving EDCA TXOPs and trying to find out how the
duration field is set...
cheers,
Claudio
next prev parent reply other threads:[~2012-05-29 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 12:06 [PATCH] mac80211: fix flag check for QoS NOACK frames Claudio Pisa
2012-05-29 7:04 ` Johannes Berg
2012-05-29 15:05 ` Claudio Pisa [this message]
2012-05-30 19:41 ` Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC4E5A1.3010508@uniroma2.it \
--to=claudio.pisa@uniroma2.it \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).