linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Dave Taht <dave.taht@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Is there no upper limit on mac80211 pending xmit queue size?
Date: Tue, 29 May 2012 14:41:01 -0700	[thread overview]
Message-ID: <4FC5426D.9000408@candelatech.com> (raw)
In-Reply-To: <CAA93jw7TiJLtL8tHNN28bpM4b_btqh4MkuqR6gL2=t2bracb+A@mail.gmail.com>

On 05/29/2012 02:37 PM, Dave Taht wrote:
> On Tue, May 29, 2012 at 2:14 PM, Ben Greear<greearb@candelatech.com>  wrote:
>> The tx pending queues doesn't seem to be limitted, allowing
>> run-away memory usage when something like pktgen is
>> sending packets faster than the system can actually
>> send them.
>>
>> [root@ct520-2011 ~]# cat /debug/ieee80211/wiphy0/queues
>> 00: 0x00000000/0
>> 01: 0x00000000/0
>> 02: 0x00000001/40076
>> 03: 0x00000000/0
>> [root@ct520-2011 ~]# cat /debug/ieee80211/wiphy0/queues
>> 00: 0x00000000/0
>> 01: 0x00000000/0
>> 02: 0x00000001/52649
>> 03: 0x00000000/0
>> [root@ct520-2011 ~]# cat /debug/ieee80211/wiphy0/queues
>> 00: 0x00000000/0
>> 01: 0x00000000/0
>> 02: 0x00000001/107939
>> 03: 0x00000000/0
>>
>> I think this is what is causing my OOM issues when sending
>> with (my hacked version of) pktgen.
>>
>> Shouldn't there be an upper limit on the number of pending frames
>> that mac80211 will queue?
>
> something bql-like would help a lot.

Might help more righteous protocols, but I'm not sure it will help
with pktgen.  I'm working on an upper limit implemented as a module
parameter.  Hopefully that will at least keep the system from
going OOM.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


      reply	other threads:[~2012-05-29 21:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-29 21:14 Is there no upper limit on mac80211 pending xmit queue size? Ben Greear
2012-05-29 21:37 ` Dave Taht
2012-05-29 21:41   ` Ben Greear [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC5426D.9000408@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=dave.taht@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).